Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(769)

Issue 5343050: Issues 1503 and 1572 - improved jazz chord support. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by adam.spiers
Modified:
12 years, 4 months ago
Reviewers:
pkx166h, dak, carl.d.sorensen, Carl
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issues 1503 and 1572 - Add an entry to changes.tely for improved jazz chord support. Issue 1503 - add support for "altered" jazz chord (super-Locrian) Fix indentation in chord-ignatzek-names.scm Doc: fix spurious pluralisation typo in Chord name chart appendix Issue 1503 - add additionalPitchPrefix to allow choice of prefix for additional pitches in chords. This was previously "add", e.g. "Cmaj7 add6add9", but this results in too much clutter and is rarely used. Issue 1503 - Allow choice of minor chord modifier. For example, often it is preferred to use a hyphen instead of "m". This can now be achieved via: \set minorChordModifier = \markup { "-" } Add slashChordSeparator Issue 1572 and issue 1503 - Allow choice of chord modifier separator independently of chord inversion separator, since conventionally the latter is always a slash (hence the term "slash chords"), whereas the former seldom involves slashes. Add some missing chords to the ignatzek regression test Issue 1503 - Recognise Lydian chords Issue 1503 - Enlarge half-diminished slashed circle symbol Replace tabs with spaces in scm/chord-ignatzek-names.scm

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+385 lines, -248 lines) Patch
M Documentation/changes.tely View 1 chunk +9 lines, -0 lines 1 comment Download
M Documentation/included/chord-names-jazz.ly View 3 chunks +82 lines, -78 lines 0 comments Download
M Documentation/notation/chords.itely View 3 chunks +74 lines, -7 lines 0 comments Download
M Documentation/notation/notation-appendices.itely View 1 chunk +1 line, -1 line 0 comments Download
A input/regression/chord-additional-pitch-prefix.ly View 1 chunk +11 lines, -0 lines 1 comment Download
A input/regression/chord-name-minor.ly View 1 chunk +13 lines, -0 lines 0 comments Download
A input/regression/chord-slash-separator.ly View 1 chunk +11 lines, -0 lines 0 comments Download
M input/regression/chords-funky-ignatzek.ly View 1 chunk +6 lines, -0 lines 0 comments Download
M ly/chord-modifiers-init.ly View 1 chunk +3 lines, -1 line 0 comments Download
M ly/engraver-init.ly View 1 chunk +4 lines, -1 line 0 comments Download
M scm/chord-ignatzek-names.scm View 3 chunks +164 lines, -160 lines 1 comment Download
M scm/define-context-properties.scm View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9
Carl
I am not in favor of the tab-to-space change in scm/chord-ignatzek-names.scm, since we don't yet ...
12 years, 4 months ago (2011-11-07 20:13:46 UTC) #1
pkx166h
Passes make but two reg test diffs - see http://code.google.com/p/lilypond/issues/detail?id=1503#c32 James
12 years, 4 months ago (2011-11-07 20:45:07 UTC) #2
adam.spiers
On Mon, Nov 7, 2011 at 9:13 PM, Graham Percival <graham@percival-music.ca> wrote: > On Mon, ...
12 years, 4 months ago (2011-11-07 21:48:28 UTC) #3
dak
Adam Spiers <adam.spiers@gmail.com> writes: > On Mon, Nov 7, 2011 at 9:13 PM, Graham Percival ...
12 years, 4 months ago (2011-11-07 22:11:46 UTC) #4
adam.spiers
On Mon, Nov 7, 2011 at 10:11 PM, David Kastrup <dak@gnu.org> wrote: > In this ...
12 years, 4 months ago (2011-11-07 22:29:14 UTC) #5
Carl
As far as I can see, this patch is approved for pushing, but hasn't been ...
12 years, 4 months ago (2011-11-27 01:21:18 UTC) #6
adam.spiers
On Sun, Nov 27, 2011 at 1:21 AM, <Carl.D.Sorensen@gmail.com> wrote: > As far as I ...
12 years, 4 months ago (2011-11-27 10:59:44 UTC) #7
dak
Adam Spiers <adam.spiers@gmail.com> writes: > On Sun, Nov 27, 2011 at 1:21 AM, <Carl.D.Sorensen@gmail.com> wrote: ...
12 years, 4 months ago (2011-11-27 11:03:14 UTC) #8
adam.spiers
12 years, 4 months ago (2011-11-28 21:21:07 UTC) #9
Pushed to staging as f955789f..0fa48c98
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b