CLWPR module for ns-3.11

This issue adds the CLWPR module to ns-3.11

CLWPR (Cross Layer, Weighted, Position-based, Routing) is a Ipv4 routing protocol for ad-hoc networks optimized for urban VANETs. Currently it is in early stages, not so much optimized, but it is highly configurable.
A recent publication that I have on this protocol and will be presented in IEEE VNC 2011 can be downloaded from my website: http://info.ee.surrey.ac.uk/Personal/K.Katsaros/papers/KK_CLWPR_VNC_11.pdf

In addition, the Winner-models module was extracted from iTETRIS platform and is included in this patch.

[Tommaso Pecorella, 2011-11-07 23:45:12]

Hi, here are some comments.

I didn't yet go in details into the core of the protocol, but there are some
things that might affect it, so better start from those ones.

http://codereview.appspot.com/5343044/diff/18/src/mobility/helper/mobility-he...
File src/mobility/helper/mobility-helper.cc (right):

http://codereview.appspot.com/5343044/diff/18/src/mobility/helper/mobility-he...
src/mobility/helper/mobility-helper.cc:43: 
Don't add blank lines when not useful.

http://codereview.appspot.com/5343044/diff/18/src/mobility/helper/mobility-he...
File src/mobility/helper/mobility-helper.h (right):

http://codereview.appspot.com/5343044/diff/18/src/mobility/helper/mobility-he...
src/mobility/helper/mobility-helper.h:29: #include "ns3/clwpr-map.h"
Again, unnecessary.

http://codereview.appspot.com/5343044/diff/18/src/mobility/model/clwpr-map.h
File src/mobility/model/clwpr-map.h (right):

http://codereview.appspot.com/5343044/diff/18/src/mobility/model/clwpr-map.h#...
src/mobility/model/clwpr-map.h:71: };
Hem... indentation ?

http://codereview.appspot.com/5343044/diff/18/src/mobility/model/constant-pos...
File src/mobility/model/constant-position-mobility-model.h (right):

http://codereview.appspot.com/5343044/diff/18/src/mobility/model/constant-pos...
src/mobility/model/constant-position-mobility-model.h:48: GridMap m_map;
Why this should be here ?
If the implementation is not changed, then this should be unnecessary, isn't it
?

http://codereview.appspot.com/5343044/diff/18/src/mobility/model/mobility-mod...
File src/mobility/model/mobility-model.cc (right):

http://codereview.appspot.com/5343044/diff/18/src/mobility/model/mobility-mod...
src/mobility/model/mobility-model.cc:118: MobilityModel::DoGetAntennaHeight
(void) const
Unnecessary function, remove. There is a getter that does the same

http://codereview.appspot.com/5343044/diff/18/src/mobility/model/mobility-mod...
File src/mobility/model/mobility-model.h (right):

http://codereview.appspot.com/5343044/diff/18/src/mobility/model/mobility-mod...
src/mobility/model/mobility-model.h:73: virtual void SetAntennaHeight (const
float &antennaHeight); // Added Ramon Bauza 21/09/10
The mobility model does not rely on antenna height. it seems "just" a place to
store an information that doesn't have anything to do with the mobility itself.
Please justify why it should be memorized here.

http://codereview.appspot.com/5343044/diff/18/src/mobility/model/mobility-mod...
src/mobility/model/mobility-model.h:74: Ptr<Node> GetNode (void) const; // Added
Ramon Bauza 16/09/10
GetNode and SetNode:
the mobility module does not use this information, so it's an unnecessary
dependance.

http://codereview.appspot.com/5343044/diff/18/src/wifi/model/yans-wifi-phy.cc
File src/wifi/model/yans-wifi-phy.cc (right):

http://codereview.appspot.com/5343044/diff/18/src/wifi/model/yans-wifi-phy.cc...
src/wifi/model/yans-wifi-phy.cc:38: #include "ns3/clwpr-routing-protocol.h"
Ouch. Noway.

http://codereview.appspot.com/5343044/diff/18/src/wifi/model/yans-wifi-phy.cc...
src/wifi/model/yans-wifi-phy.cc:793: SnrTag tag(signalDbm - noiseDbm);
If you need an SnrTag, it should be added in the yans header, not in the CLWPR
ones. Either what's using yans will use indirectly also CLWPR.
Remove unnecessary dependancies.
Moreover the fact that it's here is bounding CLWPR to WiFi implementation, and
this isn't really wonderful (tho it might be acceptable).

http://codereview.appspot.com/5343044/diff/18/src/wifi/test/wifi-phy-test.cc
File src/wifi/test/wifi-phy-test.cc (right):

http://codereview.appspot.com/5343044/diff/18/src/wifi/test/wifi-phy-test.cc#...
src/wifi/test/wifi-phy-test.cc:37: 
Don't change a file if it's "just" 2 lines.
Revert to the original.

[Konstantinos Katsaros, 2011-11-09 00:05:55]

Dear Tomasso,

Thanks for the feedback.

Regarding mobility files, those commented by Ramon Bauza are part of the 
iTETRIS and just forgot to remove them.

I have properly commented clwpr-map.h if that's what you mean with 
indentation. The use of this class is a basic navigation system.

Regarding the SnrTag, you are right, I shouldn't have included the 
clwpr-protocol.h in PHY, I only needed the SnrTag from that. I created a 
new header file in wifi module, only for SnrTag, since others might want to 
use it.

[tpecorella_mac.com, 2011-11-09 20:19:24]

Hi Kostantinos,

good, I'll move on with the review. And yes, the best place for the SnrTag is
indeed in the WiFiPhy. I could be very useful for other modules as well (e.g.,
modules to switch interfaces).

Cheers,

Tommaso



Tommaso Pecorella - Ph.D.

Assistant professor
Dpt. Elettronica e Telecomunicazioni
Università di Firenze

CNIT - Università di Firenze Unit

via di S. Marta 3
50139, Firenze
ITALY

email: tommaso.pecorella@unifi.it
       tommaso.pecorella@cnit.it

phone : +39-055-4796412
mobile: +39-320-4379803
fax   : +39-055-494569

On 09 Nov, 2011,at 01:05 AM, Kostantinos Katsaros <dinos.katsaros@gmail.com>
wrote:

Dear Tomasso,

Thanks for the feedback.

Regarding mobility files, those commented by Ramon Bauza are part of the iTETRIS
and just forgot to remove them.

I have properly commented clwpr-map.h if that's what you mean with indentation.
The use of this class is a basic navigation system.

Regarding the SnrTag, you are right, I shouldn't have included the
clwpr-protocol.h in PHY, I only needed the SnrTag from that. I created a new
header file in wifi module, only for SnrTag, since others might want to use it.

[yacine.mahmoud7, 2014-04-28 11:28:05]

On 2011/11/09 20:19:24, tpecorella_mac.com wrote:
> Hi Kostantinos,
> 
> good, I'll move on with the review. And yes, the best place for the SnrTag is
> indeed in the WiFiPhy. I could be very useful for other modules as well (e.g.,
> modules to switch interfaces).
> 
> Cheers,
> 
> Tommaso
> 
> 
> 
> Tommaso Pecorella - Ph.D.
> 
> Assistant professor
> Dpt. Elettronica e Telecomunicazioni
> Università di Firenze
> 
> CNIT - Università di Firenze Unit
> 
> via di S. Marta 3
> 50139, Firenze
> ITALY
> 
> email: mailto:tommaso.pecorella@unifi.it
>        mailto:tommaso.pecorella@cnit.it
> 
> phone : +39-055-4796412
> mobile: +39-320-4379803
> fax   : +39-055-494569
> 
> On 09 Nov, 2011,at 01:05 AM, Kostantinos Katsaros
<mailto:dinos.katsaros@gmail.com>
> wrote:
> 
> Dear Tomasso,
> 
> Thanks for the feedback.
> 
> Regarding mobility files, those commented by Ramon Bauza are part of the
iTETRIS
> and just forgot to remove them.
> 
> I have properly commented clwpr-map.h if that's what you mean with
indentation.
> The use of this class is a basic navigation system.
> 
> Regarding the SnrTag, you are right, I shouldn't have included the
> clwpr-protocol.h in PHY, I only needed the SnrTag from that. I created a new
> header file in wifi module, only for SnrTag, since others might want to use
it.

Hello, 
Please i need help for download clwpr-module.h for runnig the script. Please
Hepl me !! thank you All for this work