Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(185)

Issue 5340050: code review 5340050: renaming_1: hand-edited files for go 1 renaming (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by r
Modified:
13 years, 6 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

renaming_1: hand-edited files for go 1 renaming This contains the files that required handiwork, mostly Makefiles with updated TARGs, plus the two packages with modified package names. html/template/doc.go needs a separate edit pass. test/fixedbugs/bug358.go is not legal go so gofix fails on it.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r ae8e8c32ff4a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 890d78282ea9 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r a0b71f0eb12f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -144 lines) Patch
M doc/effective_go.html View 2 chunks +5 lines, -4 lines 0 comments Download
M doc/effective_go.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/deps.bash View 2 chunks +0 lines, -59 lines 0 comments Download
M src/pkg/encoding/asn1/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/encoding/csv/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/encoding/gob/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/encoding/json/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/encoding/xml/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/html/template/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/html/template/attr.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/html/template/clone.go View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/html/template/clone_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M src/pkg/html/template/content.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/html/template/content_test.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/html/template/context.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/html/template/css.go View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/html/template/css_test.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/html/template/doc.go View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M src/pkg/html/template/error.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/html/template/escape.go View 1 chunk +3 lines, -3 lines 0 comments Download
M src/pkg/html/template/escape_test.go View 2 chunks +5 lines, -5 lines 0 comments Download
M src/pkg/html/template/html.go View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/html/template/html_test.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/html/template/js.go View 1 chunk +3 lines, -3 lines 0 comments Download
M src/pkg/html/template/js_test.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/html/template/template.go View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/html/template/transition.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/html/template/url.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/html/template/url_test.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/log/syslog/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/math/big/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/math/cmplx/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/math/cmplx/abs.go View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/math/cmplx/asin.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/math/cmplx/cmath_test.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/math/cmplx/conj.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/math/cmplx/exp.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/math/cmplx/isinf.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/math/cmplx/isnan.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/math/cmplx/log.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/math/cmplx/phase.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/math/cmplx/polar.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/math/cmplx/pow.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/math/cmplx/rect.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/math/cmplx/sin.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/math/cmplx/sqrt.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/math/cmplx/tan.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/math/rand/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/http/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/http/cgi/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/http/fcgi/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/http/httptest/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/http/pprof/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/mail/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/rpc/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/rpc/jsonrpc/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/smtp/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/url/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/exec/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/text/scanner/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/text/tabwriter/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/text/template/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/text/template/parse/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/unicode/utf16/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/unicode/utf8/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug358.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 6 months ago (2011-11-04 20:23:18 UTC) #1
rsc
LGTM http://rsc.codereview.appspot.com/5340050/diff/1/doc/effective_go.html File doc/effective_go.html (right): http://rsc.codereview.appspot.com/5340050/diff/1/doc/effective_go.html#newcode2933 doc/effective_go.html:2933: var // Q=17, R=18 Lost most of this ...
13 years, 6 months ago (2011-11-04 20:28:54 UTC) #2
r
13 years, 6 months ago (2011-11-08 23:38:55 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=f759d7ef4e8b ***

renaming_1: hand-edited files for go 1 renaming
This contains the files that required handiwork, mostly
Makefiles with updated TARGs, plus the two packages
with modified package names.
html/template/doc.go needs a separate edit pass.
test/fixedbugs/bug358.go is not legal go so gofix fails on it.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5340050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b