Add font scaler gm.

[reed1, 2011-11-04 11:52:38]

can you upload 1 generated image as part of this initial CL, so I can see what
the gm produces?

http://codereview.appspot.com/5337044/diff/1001/src/ports/SkFontHost_FreeType...
File src/ports/SkFontHost_FreeType.cpp (left):

http://codereview.appspot.com/5337044/diff/1001/src/ports/SkFontHost_FreeType...
src/ports/SkFontHost_FreeType.cpp:951: 
nit: if (0 == ...)

http://codereview.appspot.com/5337044/diff/1001/src/ports/SkFontHost_FreeType...
File src/ports/SkFontHost_FreeType.cpp (right):

http://codereview.appspot.com/5337044/diff/1001/src/ports/SkFontHost_FreeType...
src/ports/SkFontHost_FreeType.cpp:956: glyph->fLeft = 0;
do you mean return here?

[bungeman, 2011-11-04 12:12:43]

Added images and fixed nits.

http://codereview.appspot.com/5337044/diff/1001/src/ports/SkFontHost_FreeType...
File src/ports/SkFontHost_FreeType.cpp (left):

http://codereview.appspot.com/5337044/diff/1001/src/ports/SkFontHost_FreeType...
src/ports/SkFontHost_FreeType.cpp:951: 
On 2011/11/04 11:52:39, reed1 wrote:
> nit: if (0 == ...)

Done.

http://codereview.appspot.com/5337044/diff/1001/src/ports/SkFontHost_FreeType...
File src/ports/SkFontHost_FreeType.cpp (right):

http://codereview.appspot.com/5337044/diff/1001/src/ports/SkFontHost_FreeType...
src/ports/SkFontHost_FreeType.cpp:956: glyph->fLeft = 0;
On 2011/11/04 11:52:39, reed1 wrote:
> do you mean return here?

Still need to set the advances below.

[bungeman, 2011-11-04 15:27:26]

Changed test to use slight hinting instead of normal. We should consider using
slight hinting in general, since it pretty much always looks better, and that's
what most people are using these days.

[reed1, 2011-11-04 15:37:48]

LGTM

[bungeman, 2011-11-04 15:48:18]

Committed revision 2603.

[bungeman, 2011-11-07 14:04:52]

Resized to 1450 wide to avoid changes in GPU images. Added hinting enum to
flattened paint to avoid playback mismatch. Baselines should now match what bots
expect.

[bungeman, 2011-11-07 14:50:20]

With this change the new code can read the old format (without the hinting
bits). Old code will not be able to read the new format.

[DerekS, 2011-11-07 15:13:01]

http://codereview.appspot.com/5337044/diff/23001/src/core/SkPaint.cpp
File src/core/SkPaint.cpp (right):

http://codereview.appspot.com/5337044/diff/23001/src/core/SkPaint.cpp#newcode...
src/core/SkPaint.cpp:1572: *ptr++ = (this->getFlags() << 16) |
((this->getHinting()+1) << 12) | (this->getTextAlign() << 8) | flatFlags;
Add comments here and in the deserializer about how the data is stored.

[bungeman, 2011-11-07 15:34:09]

http://codereview.appspot.com/5337044/diff/23001/src/core/SkPaint.cpp
File src/core/SkPaint.cpp (right):

http://codereview.appspot.com/5337044/diff/23001/src/core/SkPaint.cpp#newcode...
src/core/SkPaint.cpp:1572: *ptr++ = (this->getFlags() << 16) |
((this->getHinting()+1) << 12) | (this->getTextAlign() << 8) | flatFlags;
On 2011/11/07 15:13:01, djsollen wrote:
> Add comments here and in the deserializer about how the data is stored.

Done.

[DerekS, 2011-11-07 15:45:23]

LGTM

[bungeman, 2011-11-07 16:48:47]

Committed revision 2619.