Issue 5336049: code review 5336049: net/http/httputil: new package; move ClientConn and Ser...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5336049: code review 5336049: net/http/httputil: new package; move ClientConn and Ser... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by bradfitz

Modified:
12 years, 6 months ago

Reviewers:

CC:
r, rsc, golang-dev

Visibility:
Public.

Description

net/http/httputil: new package; move ClientConn and ServerConn Part of http diet plan. More of the lesser-used and newcomer-misleading parts of http will move here.

Patch Set 2 : diff -r f5b1cf2c3320 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f5b1cf2c3320 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r f5b1cf2c3320 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r c8c9ccd19020 https://go.googlecode.com/hg/ #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -26 lines)			Patch
M	src/pkg/Makefile	View	1 2 3 4	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/pkg/net/http/Makefile	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
A	src/pkg/net/http/httputil/Makefile	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/pkg/net/http/httputil/persist.go	View	1 2 3	14 chunks	+20 lines, -23 lines	0 comments	Download
M	src/pkg/net/http/serve_test.go	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 6 months ago (2011-11-03 20:44:22 UTC) #1

http://codereview.appspot.com/5336049/diff/4001/src/pkg/net/http/httputil/persist.go File src/pkg/net/http/httputil/persist.go (right): http://codereview.appspot.com/5336049/diff/4001/src/pkg/net/http/httputil/persist.go#newcode5 src/pkg/net/http/httputil/persist.go:5: package httputil package doc?

12 years, 6 months ago (2011-11-03 20:52:44 UTC) #2

bradfitz

Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 6 months ago (2011-11-03 21:34:45 UTC) #3

bradfitz

12 years, 6 months ago (2011-11-03 21:44:32 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=095cf9590ffe ***

net/http/httputil: new package; move ClientConn and ServerConn

Part of http diet plan.

More of the lesser-used and newcomer-misleading parts of http will
move here.

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/5336049

Expand All Messages | Collapse All Messages