code review 5335045: goprotobuf: update to new errors.

goprotobuf: update to new errors.
Mostly gofix, but a few needed hand-work,
such as in the generator.

[r, 2011-11-02 19:15:33]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://goprotobuf.googlecode.com/hg

[r2, 2011-11-02 19:16:31]

p.s. protobuf generated code no longer imports "os".

-rob

[bradfitz, 2011-11-02 19:19:29]

As an anecdote or does that enable something?

On Wed, Nov 2, 2011 at 12:16 PM, Rob 'Commander' Pike <r@google.com> wrote:

> p.s. protobuf generated code no longer imports "os".
>
> -rob
>
>

[r2, 2011-11-02 19:20:00]

On Nov 2, 2011, at 12:19 PM, Brad Fitzpatrick wrote:

> As an anecdote or does that enable something?
> 
> On Wed, Nov 2, 2011 at 12:16 PM, Rob 'Commander' Pike <r@google.com> wrote:
> p.s. protobuf generated code no longer imports "os".

just a fact.

-rob

[rsc, 2011-11-02 19:25:30]

Anything gofix didn't do but should have?
(Or vice versa?)

http://rsc.codereview.appspot.com/5335045/diff/1/compiler/descriptor/descript...
File compiler/descriptor/descriptor.pb.go (right):

http://rsc.codereview.appspot.com/5335045/diff/1/compiler/descriptor/descript...
compiler/descriptor/descriptor.pb.go:12: var _ error
dreg? delete

[rsc, 2011-11-02 19:25:36]

LGTM

[r2, 2011-11-02 19:31:07]

On Nov 2, 2011, at 12:25 PM, rsc@golang.org wrote:

> Anything gofix didn't do but should have?
> (Or vice versa?)

the main thing it missed was my own Error types implementing String, not Error,
but i wouldn't expect gofix to figure that out.

-rob

[rsc, 2011-11-02 19:31:52]

On Wed, Nov 2, 2011 at 15:31, Rob 'Commander' Pike <r@google.com> wrote:
> the main thing it missed was my own Error types implementing String, not
Error, but i wouldn't expect gofix to figure that out.

It usually does figure that out.  What type specifically?

[rsc, 2011-11-02 19:33:23]

On Wed, Nov 2, 2011 at 15:31, Russ Cox <rsc@golang.org> wrote:
> It usually does figure that out.  What type specifically?

This shouldn't hold up the CL, by the way.
Just trying to make gofix better for the later adopters.

Russ

[r2, 2011-11-02 19:41:40]

On Nov 2, 2011, at 12:31 PM, Russ Cox wrote:

> On Wed, Nov 2, 2011 at 15:31, Rob 'Commander' Pike <r@google.com> wrote:
>> the main thing it missed was my own Error types implementing String, not
Error, but i wouldn't expect gofix to figure that out.
> 
> It usually does figure that out.  What type specifically?

proto/text_parser.go, *ParseError

seems asking a lot for gofix to figure it out.

also this:

		t.Errorf(err.String())

which is wrong anyway (and i will fix) but imagine s/f//

-rob

[r, 2011-11-02 19:43:08]

*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=694312d6c9bb ***

goprotobuf: update to new errors.
Mostly gofix, but a few needed hand-work,
such as in the generator.

R=r, bradfitz, rsc
CC=golang-dev
http://codereview.appspot.com/5335045