code review 5333050: gopack: change archive file name length back to 16

gopack: change archive file name length back to 16

This CL grew the archive file name length from 16 to 64:

        changeset:   909:58574851d792
        user:        Russ Cox <rsc@golang.org>
        date:        Mon Oct 20 13:53:56 2008 -0700

Back then, every x.go file in a package became an x.6 file
in the archive.  It was important to be able to allow the
use of long Go source file names, hence the increase in size.

Today, all Go source files compile into a single _go_.6 file
regardless of their names, so the archive file name length
no longer needs to be long.  The longer name causes some
problems on Plan 9, where the native archive format is the
same but with 16-byte names, so revert back to 16.

[rsc, 2011-11-01 04:15:33]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-11-01 04:23:53]

LGTM

[rsc, 2011-11-01 04:29:28]

*** Submitted as http://code.google.com/p/go/source/detail?r=39729c81e276 ***

gopack: change archive file name length back to 16

This CL grew the archive file name length from 16 to 64:

        changeset:   909:58574851d792
        user:        Russ Cox <rsc@golang.org>
        date:        Mon Oct 20 13:53:56 2008 -0700

Back then, every x.go file in a package became an x.6 file
in the archive.  It was important to be able to allow the
use of long Go source file names, hence the increase in size.

Today, all Go source files compile into a single _go_.6 file
regardless of their names, so the archive file name length
no longer needs to be long.  The longer name causes some
problems on Plan 9, where the native archive format is the
same but with 16-byte names, so revert back to 16.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5333050

[lucio, 2011-11-01 09:38:57]

I'm speechless :-)

I did think that extending the file name length was a good idea and
Plan 9 can be adjusted, it's a small fix.  Ah, well!

Lucio.

On 11/1/11, rsc@golang.org <rsc@golang.org> wrote:
> *** Submitted as
> http://code.google.com/p/go/source/detail?r=39729c81e276 ***
>
> gopack: change archive file name length back to 16
>
> This CL grew the archive file name length from 16 to 64:
>
>          changeset:   909:58574851d792
>          user:        Russ Cox <rsc@golang.org>
>          date:        Mon Oct 20 13:53:56 2008 -0700
>
> Back then, every x.go file in a package became an x.6 file
> in the archive.  It was important to be able to allow the
> use of long Go source file names, hence the increase in size.
>
> Today, all Go source files compile into a single _go_.6 file
> regardless of their names, so the archive file name length
> no longer needs to be long.  The longer name causes some
> problems on Plan 9, where the native archive format is the
> same but with 16-byte names, so revert back to 16.
>
> R=golang-dev, r
> CC=golang-dev
> http://codereview.appspot.com/5333050
>
>
> http://codereview.appspot.com/5333050/
>