Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(183)

Issue 5333046: [Issue 28] JsonFactory#toString() depends on default charset (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by yanivi
Modified:
12 years, 5 months ago
Reviewers:
rmistry
Base URL:
https://google-http-java-client.googlecode.com/hg/
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : minor nit #

Messages

Total messages: 3
yanivi
12 years, 5 months ago (2011-10-31 19:06:28 UTC) #1
rmistry
LGTM http://codereview.appspot.com/5333046/diff/1/google-http-client/src/test/java/com/google/api/client/http/LogContentTest.java File google-http-client/src/test/java/com/google/api/client/http/LogContentTest.java (right): http://codereview.appspot.com/5333046/diff/1/google-http-client/src/test/java/com/google/api/client/http/LogContentTest.java#newcode66 google-http-client/src/test/java/com/google/api/client/http/LogContentTest.java:66: nit: unneeded new line
12 years, 5 months ago (2011-10-31 19:11:06 UTC) #2
yanivi
12 years, 5 months ago (2011-10-31 19:29:24 UTC) #3
Submitting...

http://codereview.appspot.com/5333046/diff/1/google-http-client/src/test/java...
File
google-http-client/src/test/java/com/google/api/client/http/LogContentTest.java
(right):

http://codereview.appspot.com/5333046/diff/1/google-http-client/src/test/java...
google-http-client/src/test/java/com/google/api/client/http/LogContentTest.java:66:

On 2011/10/31 19:11:06, rmistry wrote:
> nit: unneeded new line

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b