Issue 5333046: [Issue 28] JsonFactory#toString() depends on default charset

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5333046: [Issue 28] JsonFactory#toString() depends on default charset (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by yanivi

Modified:
13 years, 1 month ago

Reviewers:
rmistry

Base URL:
https://google-http-java-client.googlecode.com/hg/

Visibility:
Public.

Patch Set 2 : minor nit #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -3 lines)			Patch
M	google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/LogContent.java	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/json/JsonFactory.java	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/testing/json/AbstractJsonParserTest.java	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	google-http-client/src/test/java/com/google/api/client/http/LogContentTest.java	View	1	1 chunk	+66 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rmistry

LGTM http://codereview.appspot.com/5333046/diff/1/google-http-client/src/test/java/com/google/api/client/http/LogContentTest.java File google-http-client/src/test/java/com/google/api/client/http/LogContentTest.java (right): http://codereview.appspot.com/5333046/diff/1/google-http-client/src/test/java/com/google/api/client/http/LogContentTest.java#newcode66 google-http-client/src/test/java/com/google/api/client/http/LogContentTest.java:66: nit: unneeded new line

13 years, 1 month ago (2011-10-31 19:11:06 UTC) #2

yanivi

13 years, 1 month ago (2011-10-31 19:29:24 UTC) #3

Submitting...

http://codereview.appspot.com/5333046/diff/1/google-http-client/src/test/java...
File
google-http-client/src/test/java/com/google/api/client/http/LogContentTest.java
(right):

http://codereview.appspot.com/5333046/diff/1/google-http-client/src/test/java...
google-http-client/src/test/java/com/google/api/client/http/LogContentTest.java:66:

On 2011/10/31 19:11:06, rmistry wrote:
> nit: unneeded new line

Done.

Expand All Messages | Collapse All Messages