Issue 5327052: code review 5327052: strconv: use better errors than os.EINVAL, os.ERANGE

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5327052: code review 5327052: strconv: use better errors than os.EINVAL, os.ERANGE (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by rsc

Modified:
13 years, 9 months ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

strconv: use better errors than os.EINVAL, os.ERANGE

Patch Set 2 : diff -r eb6fbf796acc https://go.googlecode.com/hg #

Patch Set 3 : diff -r eb6fbf796acc https://go.googlecode.com/hg #

Total comments: 3

Patch Set 4 : diff -r 4c0477230b7d https://go.googlecode.com/hg #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -99 lines)			Patch
M	src/pkg/exp/sql/convert_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/strconv/atob.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/strconv/atob_test.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/strconv/atof.go	View	1	5 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/strconv/atof_test.go	View	1	3 chunks	+20 lines, -20 lines	0 comments	Download
M	src/pkg/strconv/atoi.go	View	1 2 3	10 chunks	+28 lines, -21 lines	0 comments	Download
M	src/pkg/strconv/atoi_test.go	View	1	7 chunks	+30 lines, -30 lines	0 comments	Download
M	src/pkg/strconv/quote.go	View	1	9 chunks	+15 lines, -15 lines	0 comments	Download
M	src/pkg/strconv/quote_test.go	View	1 2	2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

13 years, 9 months ago (2011-10-28 01:42:23 UTC) #1

adg

LGTM http://codereview.appspot.com/5327052/diff/5001/src/pkg/strconv/atoi.go File src/pkg/strconv/atoi.go (right): http://codereview.appspot.com/5327052/diff/5001/src/pkg/strconv/atoi.go#newcode12 src/pkg/strconv/atoi.go:12: // ErrSyntax indicates that a value is not ...

13 years, 9 months ago (2011-10-28 01:53:12 UTC) #2

rsc

On Thu, Oct 27, 2011 at 18:53, <adg@golang.org> wrote: > does it record or indicate? ...

13 years, 9 months ago (2011-10-28 02:45:51 UTC) #3

rsc

13 years, 9 months ago (2011-10-28 02:46:37 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=26990717694c ***

strconv: use better errors than os.EINVAL, os.ERANGE

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/5327052

Expand All Messages | Collapse All Messages