code review 5322051: src/pkg/[a-m]*: gofix -r error

src/pkg/[a-m]*: gofix -r error -force=error

[rsc, 2011-10-28 04:06:16]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
FAKE_REPOSITORY

[iant, 2011-10-29 01:15:13]

LGTM

All comments optional.

http://codereview.appspot.com/5322051/diff/2001/src/pkg/archive/zip/struct.go
File src/pkg/archive/zip/struct.go (right):

http://codereview.appspot.com/5322051/diff/2001/src/pkg/archive/zip/struct.go...
src/pkg/archive/zip/struct.go:65: if osErr, ok := e.(error); ok {
Name "osErr" should change to "err".  (Probably for later).

http://codereview.appspot.com/5322051/diff/2001/src/pkg/big/int_test.go
File src/pkg/big/int_test.go (right):

http://codereview.appspot.com/5322051/diff/2001/src/pkg/big/int_test.go#newco...
src/pkg/big/int_test.go:539: t.Errorf("#%d error: %s", i, err.Error())
I think we can s/err.Error()/err/ here.

http://codereview.appspot.com/5322051/diff/2001/src/pkg/big/rat_test.go
File src/pkg/big/rat_test.go (right):

http://codereview.appspot.com/5322051/diff/2001/src/pkg/big/rat_test.go#newco...
src/pkg/big/rat_test.go:115: t.Errorf("#%d error: %s", i, err.Error())
s/err.Error()/err/

http://codereview.appspot.com/5322051/diff/2001/src/pkg/crypto/bcrypt/bcrypt_...
File src/pkg/crypto/bcrypt/bcrypt_test.go (right):

http://codereview.appspot.com/5322051/diff/2001/src/pkg/crypto/bcrypt/bcrypt_...
src/pkg/crypto/bcrypt/bcrypt_test.go:88: t.Errorf("%s gave err %v but should
have given %v", name, err.Error(), expected.Error())
s/err.Error(), expected.Error()/err, expected/

http://codereview.appspot.com/5322051/diff/2001/src/pkg/crypto/openpgp/armor/...
File src/pkg/crypto/openpgp/armor/armor.go (right):

http://codereview.appspot.com/5322051/diff/2001/src/pkg/crypto/openpgp/armor/...
src/pkg/crypto/openpgp/armor/armor.go:12: error_ "crypto/openpgp/error"
Probably appropriate to rename crypto/openpgp/error, in a different CL.

http://codereview.appspot.com/5322051/diff/2001/src/pkg/debug/macho/file.go
File src/pkg/debug/macho/file.go (right):

http://codereview.appspot.com/5322051/diff/2001/src/pkg/debug/macho/file.go#n...
src/pkg/debug/macho/file.go:180: var err error
err should probably be a result variable.

http://codereview.appspot.com/5322051/diff/2001/src/pkg/debug/pe/file.go
File src/pkg/debug/pe/file.go (right):

http://codereview.appspot.com/5322051/diff/2001/src/pkg/debug/pe/file.go#newc...
src/pkg/debug/pe/file.go:106: var err error
err should probably be a result variable.

http://codereview.appspot.com/5322051/diff/2001/src/pkg/exp/gui/x11/conn.go
File src/pkg/exp/gui/x11/conn.go (right):

http://codereview.appspot.com/5322051/diff/2001/src/pkg/exp/gui/x11/conn.go#n...
src/pkg/exp/gui/x11/conn.go:91: log.Println("x11:", err.Error())
Perhasp s/err.Error()/err/

http://codereview.appspot.com/5322051/diff/2001/src/pkg/exp/gui/x11/conn.go#n...
src/pkg/exp/gui/x11/conn.go:110: log.Println("x11:", err.Error())
Perhaps s/err.Error()/err/

http://codereview.appspot.com/5322051/diff/2001/src/pkg/exp/gui/x11/conn.go#n...
src/pkg/exp/gui/x11/conn.go:118: log.Println("x11:", err.Error())
Perhaps s/err.Error/err/

[rsc, 2011-10-31 20:57:48]

Thanks.

I sent out 5302075 to apply most of these cleanups.
(Some were already in the tree.)
The eventual gofix will run on tip and will thus incorporate them.

>
http://codereview.appspot.com/5322051/diff/2001/src/pkg/crypto/openpgp/armor/...
> src/pkg/crypto/openpgp/armor/armor.go:12: error_ "crypto/openpgp/error"
> Probably appropriate to rename crypto/openpgp/error, in a different CL.

Agreed.  Leaving for Brad.

>
http://codereview.appspot.com/5322051/diff/2001/src/pkg/debug/macho/file.go#n...
> src/pkg/debug/macho/file.go:180: var err error
> err should probably be a result variable.

FWIW, I've been avoiding this in exported functions, because
returning (err os.Error) is noisier in the docs than just
returning os.Error.

Russ

[rsc, 2011-11-02 02:04:45]

*** Submitted as http://code.google.com/p/go/source/detail?r=b78bb4f2d2a3 ***

src/pkg/[a-m]*: gofix -r error -force=error

R=golang-dev, iant
CC=golang-dev
http://codereview.appspot.com/5322051