Rerotate next/previous engines without global engine.

Rerotate next/previous engines without global engine.


BUG=http://code.google.com/p/ibus/issues/detail?id=1331
TEST=Linux desktop

[fujiwara, 2011-10-31 03:20:11]

This update fixes to rerotate the engine list and rotate between engine_list and
register_engine_list.

[Peng, 2011-11-01 02:24:34]

http://codereview.appspot.com/5321067/diff/1/bus/ibusimpl.c
File bus/ibusimpl.c (right):

http://codereview.appspot.com/5321067/diff/1/bus/ibusimpl.c#newcode1082
bus/ibusimpl.c:1082: /* Rotate register_engine_list and engine_list. */
How about rewrite this part as:

if ( p == NULL) {
  if (is_next) {
    ...
  } 
  else {
   ..
  }
}
 
I think the readability is a litter better.

http://codereview.appspot.com/5321067/diff/1/bus/ibusimpl.c#newcode1104
bus/ibusimpl.c:1104: if (p == NULL && !is_next &&
ditto

[fujiwara, 2011-11-02 02:40:14]

Revised the patch.

On 2011/11/01 02:24:34, Peng wrote:
> http://codereview.appspot.com/5321067/diff/1/bus/ibusimpl.c
> File bus/ibusimpl.c (right):
> 
> http://codereview.appspot.com/5321067/diff/1/bus/ibusimpl.c#newcode1082
> bus/ibusimpl.c:1082: /* Rotate register_engine_list and engine_list. */
> How about rewrite this part as:
> 
> if ( p == NULL) {
>   if (is_next) {
>     ...
>   } 
>   else {
>    ..
>   }
> }
>  
> I think the readability is a litter better.
> 
> http://codereview.appspot.com/5321067/diff/1/bus/ibusimpl.c#newcode1104
> bus/ibusimpl.c:1104: if (p == NULL && !is_next &&
> ditto

[Peng, 2011-11-02 04:08:56]

lgtm. thx