Issue 5318056: code review 5318056: net: implement LookupTXT for windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5318056: code review 5318056: net: implement LookupTXT for windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by brainman

Modified:
13 years, 9 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

net: implement LookupTXT for windows

Patch Set 1 #

Patch Set 2 : diff -r 8bc07906f12c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8bc07906f12c https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r c0b08c584190 https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -10 lines)			Patch
M	src/pkg/net/lookup_test.go	View	1 2 3	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/pkg/net/lookup_windows.go	View	1 2 3	6 chunks	+19 lines, -6 lines	0 comments	Download
M	src/pkg/syscall/ztypes_windows.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-10-27 06:23:40 UTC) #1

rsc

LGTM You will need to hg sync and merge the Plan 9 TXT implementation I ...

13 years, 9 months ago (2011-10-31 16:10:39 UTC) #2

brainman

13 years, 9 months ago (2011-11-02 06:11:47 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=19bc41642ed8 ***

net: implement LookupTXT for windows

R=rsc
CC=golang-dev
http://codereview.appspot.com/5318056

http://codereview.appspot.com/5318056/diff/5001/src/pkg/net/lookup_windows.go
File src/pkg/net/lookup_windows.go (right):

http://codereview.appspot.com/5318056/diff/5001/src/pkg/net/lookup_windows.go...
src/pkg/net/lookup_windows.go:145: return nil, os.NewSyscallError("LookupTEXT",
int(e))
On 2011/10/31 16:10:39, rsc wrote:
> s/TEXT/TXT/
> or s/LookupTEXT/DnsQuery/

Done.

Expand All Messages | Collapse All Messages