Issue 5318042: code review 5318042: goprotobuf: remove unsafe from properties.go

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5318042: code review 5318042: goprotobuf: remove unsafe from properties.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by r

Modified:
14 years, 1 month ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

goprotobuf: remove unsafe from properties.go The old reflect world made unsafeness worthwhile here; it's not now.

Patch Set 1 #

Patch Set 2 : diff -r 9fe71978189f https://goprotobuf.googlecode.com/hg #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -13 lines)			Patch
	M	proto/encode.go	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	proto/properties.go	View		3 chunks	+11 lines, -10 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://goprotobuf.googlecode.com/hg

14 years, 1 month ago (2011-10-20 21:48:53 UTC) #1

14 years, 1 month ago (2011-10-20 21:51:12 UTC) #3

*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=5eccce873392 ***

goprotobuf: remove unsafe from properties.go
The old reflect world made unsafeness worthwhile here; it's not now.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5318042

Expand All Messages | Collapse All Messages