Issue 5312042: Make m_observer private.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5312042: Make m_observer private. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by hsumita

Modified:
12 years, 6 months ago

Reviewers:
shawn.p.huang, penghuang

CC:
komatsu, mukai, yusukes, nona, horo

Base URL:
git@github.com:hsumita/libpyzy.git@master

Visibility:
Public.

Make m_observer private. BUG=None TEST=Run a test.

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -13 lines)			Patch
M	src/PyZyBopomofoContext.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	src/PyZyPhoneticContext.h	View	4 chunks	+8 lines, -3 lines	0 comments	Download
M	src/PyZyPhoneticContext.cc	View	2 chunks	+18 lines, -0 lines	0 comments	Download
M	src/PyZyPinyinContext.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 1

lgtm