Issue 5312041: code review 5312041: reflect: make unsafe use of SliceHeader gc-friendly

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5312041: code review 5312041: reflect: make unsafe use of SliceHeader gc-friendly (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by rsc

Modified:
13 years, 10 months ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

reflect: make unsafe use of SliceHeader gc-friendly Revert workaround in compiler and revert test for compiler workaround. Tested that the 386 build continues to fail if the gc change is made without the reflect change.

Patch Set 1 #

Patch Set 2 : diff -r 695f7459c6bb https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 695f7459c6bb https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 992248b2adc2 https://go.googlecode.com/hg/ #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -81 lines)			Patch
M	src/cmd/gc/reflect.c	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	src/pkg/reflect/value.go	View	1 2	2 chunks	+20 lines, -9 lines	0 comments	Download
M	src/pkg/runtime/gc_test.go	View	1	2 chunks	+0 lines, -71 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 10 months ago (2011-10-18 13:35:48 UTC) #1

bradfitz

LGTM On Tue, Oct 18, 2011 at 6:35 AM, <rsc@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...

13 years, 10 months ago (2011-10-18 13:38:50 UTC) #2

rsc

13 years, 10 months ago (2011-10-18 14:03:39 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=96df3afe1c8a ***

reflect: make unsafe use of SliceHeader gc-friendly

Revert workaround in compiler and
revert test for compiler workaround.

Tested that the 386 build continues to fail if
the gc change is made without the reflect change.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5312041

Expand All Messages | Collapse All Messages