Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(304)

Issue 5310054: Add AdSense Management API sample code to repository (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by sgomes
Modified:
12 years ago
Reviewers:
jcgregorio_google
CC:
google-api-python-client_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Updating AdSense Management API samples with suggestions #

Patch Set 3 : Fix scope #

Unified diffs Side-by-side diffs Delta from patch set Stats (+518 lines, -0 lines) Patch
A samples/adsense/client_secrets.json View 1 1 chunk +9 lines, -0 lines 0 comments Download
A samples/adsense/generate_report.py View 1 chunk +65 lines, -0 lines 0 comments Download
A samples/adsense/generate_report_with_paging.py View 1 chunk +91 lines, -0 lines 0 comments Download
A samples/adsense/get_all_ad_clients.py View 1 1 chunk +58 lines, -0 lines 0 comments Download
A samples/adsense/get_all_ad_units.py View 1 1 chunk +59 lines, -0 lines 0 comments Download
A samples/adsense/get_all_custom_channels.py View 1 1 chunk +59 lines, -0 lines 0 comments Download
A samples/adsense/get_all_url_channels.py View 1 1 chunk +61 lines, -0 lines 0 comments Download
A samples/adsense/sample_utils.py View 1 2 1 chunk +116 lines, -0 lines 0 comments Download

Messages

Total messages: 4
jcgregorio_google
http://codereview.appspot.com/5310054/diff/1/samples/adsense/get_all_ad_clients.py File samples/adsense/get_all_ad_clients.py (right): http://codereview.appspot.com/5310054/diff/1/samples/adsense/get_all_ad_clients.py#newcode56 samples/adsense/get_all_ad_clients.py:56: if 'nextPageToken' in result: Use list_next() pagination. See the ...
12 years, 6 months ago (2011-10-25 17:40:25 UTC) #1
sgomes
Updated with suggested changes. http://codereview.appspot.com/5310054/diff/1/samples/adsense/get_all_ad_clients.py File samples/adsense/get_all_ad_clients.py (right): http://codereview.appspot.com/5310054/diff/1/samples/adsense/get_all_ad_clients.py#newcode56 samples/adsense/get_all_ad_clients.py:56: if 'nextPageToken' in result: On ...
12 years, 5 months ago (2011-12-07 15:24:04 UTC) #2
jcgregorio_google
LGTM On 2011/12/07 15:24:04, sgomes wrote: > Updated with suggested changes. > > http://codereview.appspot.com/5310054/diff/1/samples/adsense/get_all_ad_clients.py > ...
12 years, 5 months ago (2011-12-07 16:26:28 UTC) #3
jcgregorio_google
12 years, 5 months ago (2011-12-08 18:17:36 UTC) #4
Committed at
http://code.google.com/p/google-api-python-client/source/detail?r=e90ce87a9c5...

On 2011/12/07 16:26:28, jcgregorio_google wrote:
> LGTM
> 
> On 2011/12/07 15:24:04, sgomes wrote:
> > Updated with suggested changes.
> > 
> >
>
http://codereview.appspot.com/5310054/diff/1/samples/adsense/get_all_ad_clien...
> > File samples/adsense/get_all_ad_clients.py (right):
> > 
> >
>
http://codereview.appspot.com/5310054/diff/1/samples/adsense/get_all_ad_clien...
> > samples/adsense/get_all_ad_clients.py:56: if 'nextPageToken' in result:
> > On 2011/10/25 17:40:25, jcgregorio_google wrote:
> > > Use list_next() pagination. See the Google+ sample:
> > > 
> > > 
> > >
> >
>
http://code.google.com/p/google-plus-python-starter/source/browse/cli/plus_cl...
> > > 
> > > And:
> > > 
> > > http://code.google.com/p/google-api-python-client/wiki/Pagination
> > > 
> > > Applies to all the samples.
> > 
> > Done.
> > 
> > http://codereview.appspot.com/5310054/diff/1/samples/adsense/sample_utils.py
> > File samples/adsense/sample_utils.py (right):
> > 
> >
>
http://codereview.appspot.com/5310054/diff/1/samples/adsense/sample_utils.py#...
> > samples/adsense/sample_utils.py:34: # Set up a Flow object to be used if we
> need
> > to authenticate. This sample uses
> > On 2011/10/25 17:40:25, jcgregorio_google wrote:
> > > Please use the client_secrets.json support. See the Buzz sample:
> > > 
> > >
> >
>
http://code.google.com/p/google-api-python-client/source/browse/#hg%2525252Fs...
> > 
> > Done.
> > 
> >
>
http://codereview.appspot.com/5310054/diff/1/samples/adsense/sample_utils.py#...
> > samples/adsense/sample_utils.py:95: """Builds instance of service from local
> > discovery doc and does auth."""
> > On 2011/10/25 17:40:25, jcgregorio_google wrote:
> > > not local
> > 
> > Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b