Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(102)

Issue 5309059: Uses convert-ly to update changes stemming from the creation of a Flag grob. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by MikeSol
Modified:
12 years, 5 months ago
Reviewers:
mike, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Uses convert-ly to update changes stemming from the creation of a Flag grob.

Patch Set 1 #

Total comments: 18
Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -42 lines) Patch
M Documentation/cs/learning/tweaks.itely View 5 chunks +5 lines, -1 line 0 comments Download
M Documentation/de/learning/tweaks.itely View 5 chunks +5 lines, -1 line 0 comments Download
M Documentation/de/notation/ancient.itely View 5 chunks +6 lines, -2 lines 0 comments Download
M Documentation/de/notation/changing-defaults.itely View 4 chunks +4 lines, -1 line 0 comments Download
M Documentation/de/notation/percussion.itely View 6 chunks +6 lines, -1 line 0 comments Download
M Documentation/es/learning/tweaks.itely View 5 chunks +5 lines, -1 line 1 comment Download
M Documentation/es/notation/ancient.itely View 5 chunks +6 lines, -2 lines 1 comment Download
M Documentation/es/notation/changing-defaults.itely View 4 chunks +4 lines, -1 line 2 comments Download
M Documentation/es/notation/percussion.itely View 6 chunks +6 lines, -1 line 0 comments Download
M Documentation/fr/learning/tweaks.itely View 5 chunks +5 lines, -1 line 0 comments Download
M Documentation/fr/notation/changing-defaults.itely View 4 chunks +4 lines, -1 line 0 comments Download
M Documentation/fr/notation/percussion.itely View 6 chunks +6 lines, -1 line 0 comments Download
M Documentation/hu/usage/lilypond-book.itely View 1 chunk +1 line, -1 line 1 comment Download
M Documentation/it/usage/external.itely View 1 chunk +1 line, -1 line 1 comment Download
M Documentation/it/usage/lilypond-book.itely View 1 chunk +1 line, -1 line 1 comment Download
M Documentation/ja/learning/tweaks.itely View 5 chunks +5 lines, -1 line 0 comments Download
M Documentation/ja/notation/changing-defaults.itely View 4 chunks +4 lines, -1 line 2 comments Download
M Documentation/learning/tweaks.itely View 5 chunks +5 lines, -1 line 2 comments Download
M Documentation/notation/ancient.itely View 4 chunks +5 lines, -2 lines 0 comments Download
M Documentation/notation/changing-defaults.itely View 2 chunks +2 lines, -1 line 0 comments Download
M Documentation/notation/keyboards.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/notation/percussion.itely View 6 chunks +6 lines, -1 line 0 comments Download
M Documentation/snippets/drawing-boxes-around-grobs.ly View 2 chunks +3 lines, -1 line 0 comments Download
M Documentation/snippets/marking-notes-of-spoken-parts-with-a-cross-on-the-stem.ly View 2 chunks +2 lines, -1 line 0 comments Download
M Documentation/snippets/new/guitar-slides.ly View 2 chunks +2 lines, -1 line 1 comment Download
M Documentation/snippets/recorder-fingering-chart.ly View 2 chunks +2 lines, -1 line 0 comments Download
M Documentation/web/ly-examples/bach-schenker.ly View 15 chunks +22 lines, -1 line 0 comments Download
M Documentation/web/ly-examples/cary.ly View 4 chunks +4 lines, -3 lines 2 comments Download
M Documentation/web/ly-examples/granados.ly View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/web/ly-examples/tab-example.ly View 2 chunks +2 lines, -1 line 0 comments Download
M input/regression/cue-clef-after-barline.ly View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/cue-clef-manually.ly View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/event-listener-output.ly View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/grid-lines.ly View 2 chunks +2 lines, -1 line 1 comment Download
M input/regression/page-spacing-nonstaff-lines-independent.ly View 1 chunk +1 line, -1 line 0 comments Download
A input/regression/spanner-alignment.ly View 0 chunks +-1 lines, --1 lines 0 comments Download
M ly/engraver-init.ly View 2 chunks +2 lines, -1 line 0 comments Download
M ly/gregorian.ly View 2 chunks +2 lines, -1 line 1 comment Download
M ly/property-init.ly View 3 chunks +3 lines, -1 line 2 comments Download

Messages

Total messages: 3
dak
Seems like my suggestion to update the version numbers of files with manual fixes (in ...
12 years, 5 months ago (2011-10-24 21:41:04 UTC) #1
mike_apollinemike.com
On Oct 24, 2011, at 11:41 PM, dak@gnu.org wrote: > Seems like my suggestion to ...
12 years, 5 months ago (2011-10-25 05:08:38 UTC) #2
dak
12 years, 5 months ago (2011-10-25 09:52:04 UTC) #3
"mike@apollinemike.com" <mike@apollinemike.com> writes:

> On Oct 24, 2011, at 11:41 PM, dak@gnu.org wrote:
>
>> Seems like my suggestion to update the version numbers of files with
>> manual fixes (in a separate commit) in order not to get them updated
>> again got lost, as well as the bit about rereading the diff for
>> problems.
>> 
>> 
>
> I'll redo the patch - I did read the diff for updates, and I have no
> clue why these didn't show up (maybe I was reading it from the wrong
> directory - I read what came out from git diff).
> I didn't realize that the international snippets would not get
> regenerated from scratch with the new updated snippets before having
> the convert-ly rules applied to them.  All of the offending examples
> come from them.
> As for the versioning, I am not sure how to do manual updating and run
> the conversion scripts at the same time.

You don't.  When you manually update a file, update it complete _and_
edit its version string to indicate it has been updated.

After that, the conversion scripts will not touch it.

-- 
David Kastrup
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b