Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2425)

Issue 5308080: code review 5308080: snappy: delete the varint package in favor of the standard (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by nigeltao
Modified:
12 years, 6 months ago
Reviewers:
CC:
bradfitz, golang-dev
Visibility:
Public.

Description

snappy: delete the varint package in favor of the standard encoding/binary package.

Patch Set 1 #

Patch Set 2 : diff -r e4471433e554 https://code.google.com/p/snappy-go/ #

Patch Set 3 : diff -r e4471433e554 https://code.google.com/p/snappy-go/ #

Patch Set 4 : diff -r e4471433e554 https://code.google.com/p/snappy-go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -225 lines) Patch
M Makefile View 1 1 chunk +0 lines, -2 lines 0 comments Download
M snappy/decode.go View 1 2 chunks +2 lines, -3 lines 0 comments Download
M snappy/encode.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
R varint/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R varint/varint.go View 1 1 chunk +0 lines, -50 lines 0 comments Download
R varint/varint_test.go View 1 1 chunk +0 lines, -70 lines 0 comments Download
R varint/zigzag/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R varint/zigzag/zigzag.go View 1 1 chunk +0 lines, -32 lines 0 comments Download
R varint/zigzag/zigzag_test.go View 1 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 3
nigeltao
Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/snappy-go/
12 years, 6 months ago (2011-11-03 23:10:55 UTC) #1
bradfitz
LGTM On Thu, Nov 3, 2011 at 4:10 PM, <nigeltao@golang.org> wrote: > Reviewers: bradfitz, > ...
12 years, 6 months ago (2011-11-07 23:15:53 UTC) #2
nigeltao
12 years, 6 months ago (2011-11-07 23:34:08 UTC) #3
*** Submitted as eda18139736a ***

snappy: delete the varint package in favor of the standard
encoding/binary package.

R=bradfitz
CC=golang-dev
http://codereview.appspot.com/5308080
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b