Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2143)

Issue 5308067: [lto] Also stream TYPE_ADDR_SPACE. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by Diego Novillo
Modified:
12 years, 1 month ago
Reviewers:
CC:
rguenther_suse.de, gcc-patches_gcc.gnu.org
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M gcc/ChangeLog View 1 chunk +7 lines, -0 lines 0 comments Download
M gcc/tree-streamer-in.c View 1 chunk +4 lines, -1 line 0 comments Download
M gcc/tree-streamer-out.c View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 1
Diego Novillo
12 years, 6 months ago (2011-10-30 22:25:19 UTC) #1
I found this on the PPH branch.  We were not handling TYPE_ADDR_SPACE
in the streamer.

Fixed with this patch.  Richi, I will apply it on trunk unless you
remember some reason why we never streamed this?  It does not seem to
affect any LTO tests.

Tested with lto profiledbootstrap on x86_64.


Diego.


	* tree-streamer-out.c (pack_ts_base_value_fields): Emit
	TYPE_ADDR_SPACE.
	* tree-streamer-in.c (unpack_ts_base_value_fields): Read
	TYPE_ADDR_SPACE.

diff --git a/gcc/tree-streamer-in.c b/gcc/tree-streamer-in.c
index db2bb37..86eb9ce 100644
--- a/gcc/tree-streamer-in.c
+++ b/gcc/tree-streamer-in.c
@@ -130,7 +130,10 @@ unpack_ts_base_value_fields (struct bitpack_d *bp, tree
expr)
   TREE_PROTECTED (expr) = (unsigned) bp_unpack_value (bp, 1);
   TREE_DEPRECATED (expr) = (unsigned) bp_unpack_value (bp, 1);
   if (TYPE_P (expr))
-    TYPE_SATURATING (expr) = (unsigned) bp_unpack_value (bp, 1);
+    {
+      TYPE_SATURATING (expr) = (unsigned) bp_unpack_value (bp, 1);
+      TYPE_ADDR_SPACE (expr) = (unsigned) bp_unpack_value (bp, 8);
+    }
   else if (TREE_CODE (expr) == SSA_NAME)
     SSA_NAME_IS_DEFAULT_DEF (expr) = (unsigned) bp_unpack_value (bp, 1);
   else
diff --git a/gcc/tree-streamer-out.c b/gcc/tree-streamer-out.c
index 58be0a3..c46859f 100644
--- a/gcc/tree-streamer-out.c
+++ b/gcc/tree-streamer-out.c
@@ -100,7 +100,10 @@ pack_ts_base_value_fields (struct bitpack_d *bp, tree expr)
   bp_pack_value (bp, TREE_PROTECTED (expr), 1);
   bp_pack_value (bp, TREE_DEPRECATED (expr), 1);
   if (TYPE_P (expr))
-    bp_pack_value (bp, TYPE_SATURATING (expr), 1);
+    {
+      bp_pack_value (bp, TYPE_SATURATING (expr), 1);
+      bp_pack_value (bp, TYPE_ADDR_SPACE (expr), 8);
+    }
   else if (TREE_CODE (expr) == SSA_NAME)
     bp_pack_value (bp, SSA_NAME_IS_DEFAULT_DEF (expr), 1);
   else
-- 
1.7.3.1


--
This patch is available for review at http://codereview.appspot.com/5308067
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b