Issue 5308042: code review 5308042: old/regexp, old/template, template: use rune

Issue 5308042: code review 5308042: old/regexp, old/template, template: use rune (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by rsc

Modified:
13 years, 9 months ago

Reviewers:

CC:
r, gri, golang-dev

Visibility:
Public.

Description

old/regexp, old/template, template: use rune Nothing terribly interesting here.

Patch Set 2 : diff -r 3213129c689b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2036892ab207 https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 4 : diff -r 2036892ab207 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 85a91c18c661 https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -43 lines)			Patch
M	src/pkg/old/regexp/regexp.go	View	1 2 3	19 chunks	+24 lines, -24 lines	0 comments	Download
M	src/pkg/old/template/parse.go	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/template/exec_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/template/funcs.go	View	1	3 chunks	+7 lines, -7 lines	0 comments	Download
M	src/pkg/template/parse/lex.go	View	1	3 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-10-19 17:27:55 UTC) #1

gri

http://codereview.appspot.com/5308042/diff/5001/src/pkg/old/regexp/regexp.go File src/pkg/old/regexp/regexp.go (right): http://codereview.appspot.com/5308042/diff/5001/src/pkg/old/regexp/regexp.go#newcode288 src/pkg/old/regexp/regexp.go:288: func escape(c rune) rune { the result should be ...

13 years, 9 months ago (2011-10-19 18:20:43 UTC) #2

gri is right about esacpe; otherwise LGTM http://codereview.appspot.com/5308042/diff/5001/src/pkg/old/regexp/regexp.go File src/pkg/old/regexp/regexp.go (right): http://codereview.appspot.com/5308042/diff/5001/src/pkg/old/regexp/regexp.go#newcode122 src/pkg/old/regexp/regexp.go:122: char rune ...

13 years, 9 months ago (2011-10-19 18:32:25 UTC) #3

rsc

Thanks. > http://codereview.appspot.com/5308042/diff/5001/src/pkg/old/regexp/regexp.go#newcode288 > src/pkg/old/regexp/regexp.go:288: func escape(c rune) rune { > the result should be ...

13 years, 9 months ago (2011-10-19 18:59:16 UTC) #4

rsc

13 years, 9 months ago (2011-10-26 05:22:48 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=cb2e966ed5fe ***

old/regexp, old/template, template: use rune

Nothing terribly interesting here.

R=r, gri
CC=golang-dev
http://codereview.appspot.com/5308042

Expand All Messages | Collapse All Messages