LGTM On Mon, Oct 31, 2011 at 1:47 PM, <rsc@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
13 years, 7 months ago
(2011-10-31 21:15:07 UTC)
#2
LGTM
On Mon, Oct 31, 2011 at 1:47 PM, <rsc@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> test: make bug107 os.Error-proof
>
> Please review this at
http://codereview.appspot.com/**5306087/<http://codereview.appspot.com/5306087/>
>
> Affected files:
> M test/fixedbugs/bug107.go
>
>
> Index: test/fixedbugs/bug107.go
> ==============================**==============================**=======
> --- a/test/fixedbugs/bug107.go
> +++ b/test/fixedbugs/bug107.go
> @@ -6,7 +6,7 @@
>
> package main
> import os "os"
> -type _ os.Error
> +type _ os.FileInfo
> func f() (os int) {
> // In the next line "os" should refer to the result variable, not
> // to the package.
>
>
>
Issue 5306087: code review 5306087: test: make bug107 os.Error-proof
(Closed)
Created 13 years, 7 months ago by rsc
Modified 13 years, 7 months ago
Reviewers:
Base URL:
Comments: 0