code review 5306065: template: fix error checking on execute without parse

template: fix error checking on execute without parse

Fixed error checking in exec.go to give a sensible error message when
execution is attempted before a successful parse (rather than an
outright panic).

[bytbox, 2011-10-26 06:10:42]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bytbox, 2011-10-26 06:23:46]

Disregard this for now - it breaks the tests for some reason. Sorry for the
noise.

[bytbox, 2011-10-26 06:52:24]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[bytbox, 2011-10-26 06:53:29]

A couple of tests in exp/template/html were relying on inappropriate panics from
Execute - these have been fixed and all tests pass. PTAL.

[rsc, 2011-10-26 17:55:15]

R=r

[r, 2011-10-31 23:05:14]

LGTM

[r, 2011-10-31 23:07:21]

*** Submitted as http://code.google.com/p/go/source/detail?r=4866e8431426 ***

template: fix error checking on execute without parse

Fixed error checking in exec.go to give a sensible error message when
execution is attempted before a successful parse (rather than an
outright panic).

R=r
CC=golang-dev
http://codereview.appspot.com/5306065

Committer: Rob Pike <r@golang.org>