Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 5306047: code review 5306047: goprotobuf: remove unsafe from the extensions code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by r
Modified:
14 years ago
Reviewers:
CC:
golang-dev, r2, dsymonds
Visibility:
Public.

Description

goprotobuf: remove unsafe from the extensions code.

Patch Set 1 #

Patch Set 2 : diff -r 9fe71978189f https://goprotobuf.googlecode.com/hg #

Patch Set 3 : diff -r 9fe71978189f https://goprotobuf.googlecode.com/hg #

Patch Set 4 : diff -r 9fe71978189f https://goprotobuf.googlecode.com/hg #

Patch Set 5 : diff -r 9fe71978189f https://goprotobuf.googlecode.com/hg #

Total comments: 1

Patch Set 6 : diff -r 5eccce873392 https://goprotobuf.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M proto/extensions.go View 1 2 3 4 5 2 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 6
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://goprotobuf.googlecode.com/hg
14 years ago (2011-10-20 20:37:16 UTC) #1
r2
hold
14 years ago (2011-10-20 20:59:07 UTC) #2
r
Hello golang-dev@googlegroups.com, r@google.com (cc: golang-dev@googlegroups.com), Please take another look.
14 years ago (2011-10-20 21:14:33 UTC) #3
r
Hello golang-dev@googlegroups.com, r@google.com (cc: golang-dev@googlegroups.com), Please take another look.
14 years ago (2011-10-20 21:21:56 UTC) #4
dsymonds
LGTM http://codereview.appspot.com/5306047/diff/9001/proto/extensions.go File proto/extensions.go (right): http://codereview.appspot.com/5306047/diff/9001/proto/extensions.go#newcode200 proto/extensions.go:200: // t is (probably) type *ExtensionTypeFromUser. t is ...
14 years ago (2011-10-20 21:57:51 UTC) #5
r
14 years ago (2011-10-20 22:20:06 UTC) #6
*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=d23f573f6589 ***

goprotobuf: remove unsafe from the extensions code.

R=golang-dev, r, dsymonds
CC=golang-dev
http://codereview.appspot.com/5306047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b