Issue 5306047: code review 5306047: goprotobuf: remove unsafe from the extensions code.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5306047: code review 5306047: goprotobuf: remove unsafe from the extensions code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by r

Modified:
14 years ago

Reviewers:

CC:
golang-dev, r2, dsymonds

Visibility:
Public.

Description

goprotobuf: remove unsafe from the extensions code.

Patch Set 2 : diff -r 9fe71978189f https://goprotobuf.googlecode.com/hg #

Patch Set 3 : diff -r 9fe71978189f https://goprotobuf.googlecode.com/hg #

Patch Set 4 : diff -r 9fe71978189f https://goprotobuf.googlecode.com/hg #

Patch Set 5 : diff -r 9fe71978189f https://goprotobuf.googlecode.com/hg #

Total comments: 1

Patch Set 6 : diff -r 5eccce873392 https://goprotobuf.googlecode.com/hg #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -8 lines)			Patch
	M	proto/extensions.go	View	1 2 3 4 5	2 chunks	+7 lines, -8 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://goprotobuf.googlecode.com/hg

14 years ago (2011-10-20 20:37:16 UTC) #1

Hello golang-dev@googlegroups.com, r@google.com (cc: golang-dev@googlegroups.com), Please take another look.

14 years ago (2011-10-20 21:14:33 UTC) #3

Hello golang-dev@googlegroups.com, r@google.com (cc: golang-dev@googlegroups.com), Please take another look.

14 years ago (2011-10-20 21:21:56 UTC) #4

dsymonds

LGTM http://codereview.appspot.com/5306047/diff/9001/proto/extensions.go File proto/extensions.go (right): http://codereview.appspot.com/5306047/diff/9001/proto/extensions.go#newcode200 proto/extensions.go:200: // t is (probably) type *ExtensionTypeFromUser. t is ...

14 years ago (2011-10-20 21:57:51 UTC) #5

14 years ago (2011-10-20 22:20:06 UTC) #6

*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=d23f573f6589 ***

goprotobuf: remove unsafe from the extensions code.

R=golang-dev, r, dsymonds
CC=golang-dev
http://codereview.appspot.com/5306047

Expand All Messages | Collapse All Messages