Issue 5305045: code review 5305045: fmt: use rune

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5305045: code review 5305045: fmt: use rune (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by rsc

Modified:
13 years, 9 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

fmt: use rune Lots of internal edits. Formatter and Scanner interfaces change (clients to be checked by govet).

Patch Set 2 : diff -r 3213129c689b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2036892ab207 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 2036892ab207 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 07c18bcecd0f https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -103 lines)			Patch
M	src/pkg/fmt/fmt_test.go	View	1 2 3 4	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/fmt/format.go	View	1	4 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/fmt/print.go	View	1 2 3 4	18 chunks	+22 lines, -22 lines	0 comments	Download
M	src/pkg/fmt/scan.go	View	1	29 chunks	+66 lines, -65 lines	0 comments	Download
M	src/pkg/fmt/scan_test.go	View	1	5 chunks	+7 lines, -8 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-10-19 17:26:38 UTC) #1

LGTM http://codereview.appspot.com/5305045/diff/5001/src/pkg/fmt/fmt_test.go File src/pkg/fmt/fmt_test.go (right): http://codereview.appspot.com/5305045/diff/5001/src/pkg/fmt/fmt_test.go#newcode591 src/pkg/fmt/fmt_test.go:591: really? seems like debugging that should be deleted.

13 years, 9 months ago (2011-10-19 18:17:27 UTC) #2

rsc

> really? seems like debugging that should be deleted. indeed, done. that was a terrible ...

13 years, 9 months ago (2011-10-19 18:21:48 UTC) #3

rsc

13 years, 9 months ago (2011-10-26 05:21:36 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=7eac1e927d24 ***

fmt: use rune

Lots of internal edits.

Formatter and Scanner interfaces change
(clients to be checked by govet).

R=r
CC=golang-dev
http://codereview.appspot.com/5305045

http://codereview.appspot.com/5305045/diff/5001/src/pkg/fmt/fmt_test.go
File src/pkg/fmt/fmt_test.go (right):

http://codereview.appspot.com/5305045/diff/5001/src/pkg/fmt/fmt_test.go#newco...
src/pkg/fmt/fmt_test.go:591: 
On 2011/10/19 18:17:27, r wrote:
> really? seems like debugging that should be deleted.

Done.

Expand All Messages | Collapse All Messages