Issue 5305043: code review 5305043: big: handle aliasing correctly for Rat.SetFrac.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5305043: code review 5305043: big: handle aliasing correctly for Rat.SetFrac. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by gri

Modified:
13 years, 10 months ago

Reviewers:

CC:
r, rsc, golang-dev

Visibility:
Public.

Description

big: handle aliasing correctly for Rat.SetFrac. Fixes issue 2379.

Patch Set 1 #

Patch Set 2 : diff -r 3198ce30ea39 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3198ce30ea39 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 3198ce30ea39 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 2f3069984333 https://go.googlecode.com/hg/ #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -2 lines)			Patch
	M	src/pkg/big/rat.go	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
	M	src/pkg/big/rat_test.go	View	1 2	1 chunk	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 10 months ago (2011-10-18 18:43:06 UTC) #1

gri

13 years, 10 months ago (2011-10-18 19:40:44 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=c95a69e5ec20 ***

big: handle aliasing correctly for Rat.SetFrac.

Fixes issue 2379.

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/5305043

Expand All Messages | Collapse All Messages