Issue 5303080: Add null gl context, use in bench and sampleapp

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5303080: Add null gl context, use in bench and sampleapp (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by bsalomon

Modified:
12 years, 6 months ago

Reviewers:
TomH, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 1

Patch Set 3 : Add null interface to GLInterfaceValidation unit test #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+675 lines, -32 lines)			Patch
M	bench/benchmain.cpp	View		8 chunks	+18 lines, -12 lines	0 comments	Download
M	gyp/gpu.gyp	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	include/gpu/GrGLInterface.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	include/gpu/SkMesaGLContext.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	include/gpu/SkNativeGLContext.h	View		1 chunk	+1 line, -1 line	0 comments	Download
A	include/gpu/SkNullGLContext.h	View		1 chunk	+27 lines, -0 lines	0 comments	Download
M	samplecode/SampleApp.h	View	1	3 chunks	+4 lines, -3 lines	0 comments	Download
M	samplecode/SampleApp.cpp	View	1	8 chunks	+73 lines, -15 lines	0 comments	Download
A	src/gpu/GrGLCreateNullInterface.cpp	View		1 chunk	+528 lines, -0 lines	0 comments	Download
A	src/gpu/SkNullGLContext.cpp	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	tests/GLInterfaceValidation.cpp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

TomH

12 years, 6 months ago (2011-10-27 20:30:04 UTC) #2

LGTM

http://codereview.appspot.com/5303080/diff/1001/src/gpu/GrGLCreateNullInterfa...
File src/gpu/GrGLCreateNullInterface.cpp (right):

http://codereview.appspot.com/5303080/diff/1001/src/gpu/GrGLCreateNullInterfa...
src/gpu/GrGLCreateNullInterface.cpp:106: GrGLvoid GR_GL_FUNCTION_TYPE
nullGLBindFragDataLocationIndexed(GrGLuint program, GrGLuint colorNumber,
GrGLuint index, const GrGLchar * name) {}
And you were trying to spare *me* from repetitive coding?

Expand All Messages | Collapse All Messages