Issue 5303063: musicexp.py: Fix for issue 1985

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5303063: musicexp.py: Fix for issue 1985 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by pl_s

Modified:
12 years, 2 months ago

Reviewers:
Graham Percival, Reinhold

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

musicexp.py: Fix for issue 1985 The musicxml value 'none' of the group-symbol element is now converted to 'SystemStartBar' instead of 'f', the compilation of which lead to a bus error/seg fault.

Patch Set 1 #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	python/musicexp.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

pl_s

I uploaded a patch for Issue 1985: musicxml2ly: group-symbol none leads to bus error.

12 years, 6 months ago (2011-10-23 12:14:13 UTC) #1

pl_s

On 2011/10/24 09:47:45, Reinhold wrote: > LGTM. Hi, I know it's only a one-liner but ...

12 years, 2 months ago (2012-02-11 20:55:34 UTC) #3

Graham Percival

On 2012/02/11 20:55:34, pl_s wrote: > I know it's only a one-liner but it still ...

12 years, 2 months ago (2012-02-11 21:01:04 UTC) #4

pl_s

12 years, 2 months ago (2012-02-11 21:04:05 UTC) #5

On 2012/02/11 21:01:04, Graham Percival wrote:
> On 2012/02/11 20:55:34, pl_s wrote:
> > I know it's only a one-liner but it still fixes a bus error. Is there any
> > specific reason why this patch has never been pushed?
> 
> It was pushed a week ago?
> http://code.google.com/p/lilypond/issues/detail?id=1985
> 
> You're the only person that can close this codereview issue.
> 
> - Graham

Thanks, will close it.

Expand All Messages | Collapse All Messages