Issue 5301042: code review 5301042: html: parse raw text and RCDATA elements, such as <scri...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5301042: code review 5301042: html: parse raw text and RCDATA elements, such as <scri... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by nigeltao

Modified:
13 years, 9 months ago

Reviewers:

CC:
andybalholm, golang-dev

Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : diff -r 01e14745c957 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 01e14745c957 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 01e14745c957 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 5 : diff -r 3213129c689b https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+209 lines, -21 lines)			Patch
M	src/pkg/html/parse.go	View	1 2 3 4	4 chunks	+32 lines, -2 lines	0 comments	Download
M	src/pkg/html/parse_test.go	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/html/render.go	View	1 2 3 4	2 chunks	+24 lines, -14 lines	0 comments	Download
M	src/pkg/html/token.go	View	1	6 chunks	+78 lines, -1 line	0 comments	Download
M	src/pkg/html/token_test.go	View	1 2 3	1 chunk	+71 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello andybalholm@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-10-18 07:22:24 UTC) #1

andybalholm

LGTM Checking the tag name when processing the start tag makes for a cleaner design. ...

13 years, 9 months ago (2011-10-18 15:38:06 UTC) #2

nigeltao

13 years, 9 months ago (2011-10-18 21:03:41 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=46d9fdf81394 ***

html: parse raw text and RCDATA elements, such as <script> and <title>.

Pass tests1.dat, test 26:
#data
<script><div></script></div><title><p></title><p><p>
#document
| <html>
|   <head>
|     <script>
|       "<div>"
|     <title>
|       "<p>"
|   <body>
|     <p>
|     <p>

Thanks to Andy Balholm for driving this change.

R=andybalholm
CC=golang-dev
http://codereview.appspot.com/5301042

Expand All Messages | Collapse All Messages