Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(963)

Issue 5299048: Make Makefile a little more complaint (CXX, CPPFLAGS) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by Stefano Rivera
Modified:
12 years, 5 months ago
Reviewers:
CC:
rsc, re2-dev_googlegroups.com
Visibility:
Public.

Description

Make Makefile a little more complaint (CXX, CPPFLAGS) CXX should specify the C++ Compiler CPPFLAGS shouldn't be ignored Remove unnecessary rules for building C (there isn't any) Fixes issue 41

Patch Set 1 #

Patch Set 2 : diff -r f81ca23d44a4 https://re2.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -24 lines) Patch
M Makefile View 1 5 chunks +12 lines, -24 lines 0 comments Download

Messages

Total messages: 2
Stefano Rivera
12 years, 5 months ago (2011-10-19 21:28:28 UTC) #1
rsc
12 years, 5 months ago (2011-10-23 21:48:02 UTC) #2
*** Submitted as http://code.google.com/p/re2/source/detail?r=bbf8cedc561c ***

Make Makefile a little more compliant (CXX, CPPFLAGS)
CXX should specify the C++ Compiler
CPPFLAGS shouldn't be ignored
Remove unnecessary rules for building C (there isn't any)

Fixes issue 41

R=rsc
CC=re2-dev
http://codereview.appspot.com/5299048

Committer: Russ Cox <rsc@swtch.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b