Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(103)

Issue 5297048: code review 5297048: go/ast: use single-element map in test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by gri
Modified:
13 years, 9 months ago
Reviewers:
CC:
rsc, iant, iant2, golang-dev
Visibility:
Public.

Description

go/ast: use single-element map in test Avoids test failure due to undefined map iteration order.

Patch Set 1 #

Patch Set 2 : diff -r f6d1d19dec9e https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/pkg/go/ast/print_test.go View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 3
gri
Hello rsc, iant (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 9 months ago (2011-10-20 18:42:00 UTC) #1
iant2
LGTM gri@golang.org writes: > Reviewers: rsc, iant, > > Message: > Hello rsc, iant (cc: ...
13 years, 9 months ago (2011-10-20 19:00:56 UTC) #2
gri
13 years, 9 months ago (2011-10-20 19:37:18 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=37aa28ab346c ***

go/ast: use single-element map in test

Avoids test failure due to undefined map iteration order.

R=rsc, iant, iant
CC=golang-dev
http://codereview.appspot.com/5297048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b