Issue 5296045: re2_test.cc: Ask sysconf() for pagesize rather than ass...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5296045: re2_test.cc: Ask sysconf() for pagesize rather than ass... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by Stefano Rivera

Modified:
12 years, 6 months ago

Reviewers:
rsc_swtch

CC:
rsc, re2-dev_googlegroups.com

Visibility:
Public.

Description

re2_test.cc: Ask sysconf() for pagesize rather than assuming multiple of 8k Tests fail on Debian/ia64 because ia64 has 16k pages, but we try to munmap an 8k page. Fixes issue 45

Patch Set 1 #

Patch Set 2 : diff -r f81ca23d44a4 https://re2.googlecode.com/hg #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	re2/testing/re2_test.cc	View	1	1 chunk	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

*** Submitted as http://code.google.com/p/re2/source/detail?r=67e969a063d4 *** re2_test.cc: Ask sysconf() for pagesize rather than assuming multiple of ...

12 years, 6 months ago (2011-10-23 21:50:39 UTC) #2

LGTM

Thanks for this and the other fixes.

Expand All Messages | Collapse All Messages