Issue 5293046: code review 5293046: gc: introduce rune

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5293046: code review 5293046: gc: introduce rune (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by rsc

Modified:
13 years, 8 months ago

Reviewers:

CC:
ken2, r, golang-dev

Visibility:
Public.

Description

gc: introduce rune

Patch Set 1 #

Patch Set 2 : diff -r 3213129c689b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2036892ab207 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 28ff863d7f2e https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+186 lines, -35 lines)			Patch
M	src/cmd/gc/Makefile	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/gc/builtin.c.boot	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/cmd/gc/export.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/go.h	View	1 2	4 chunks	+5 lines, -0 lines	0 comments	Download
M	src/cmd/gc/lex.c	View	1 2	7 chunks	+78 lines, -3 lines	0 comments	Download
M	src/cmd/gc/obj.c	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/range.c	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/gc/reflect.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/runtime.go	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/cmd/gc/subr.c	View	1	4 chunks	+12 lines, -5 lines	0 comments	Download
M	src/cmd/gc/typecheck.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/walk.c	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/cmd/gopack/ar.c	View	1 2	2 chunks	+48 lines, -6 lines	0 comments	Download
M	src/cmd/ld/lib.c	View	1 2	2 chunks	+22 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/string.goc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2, r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-10-19 17:26:03 UTC) #1

rsc

13 years, 8 months ago (2011-10-26 05:19:45 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=17b7ee801b10 ***

gc: introduce rune

R=ken, r
CC=golang-dev
http://codereview.appspot.com/5293046

Expand All Messages | Collapse All Messages