code review 5293043: fmt: fix test relying on map iteration order.

fmt: fix test relying on map iteration order.

This fixes the 386 builds.

[dsymonds, 2011-10-18 00:21:32]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[dsymonds, 2011-10-18 00:22:14]

I thought I saw this fly by this morning, but I can't find it now.
Either way, the 386 builds are currently broken because of this.

[adg, 2011-10-18 00:45:19]

LGTM

http://codereview.appspot.com/5293043/diff/4001/src/pkg/fmt/fmt_test.go
File src/pkg/fmt/fmt_test.go (right):

http://codereview.appspot.com/5293043/diff/4001/src/pkg/fmt/fmt_test.go#newco...
src/pkg/fmt/fmt_test.go:353: {"%#v", map[string]B{"a": {1, 2}}, `map[string]
fmt_test.B{"a":fmt_test.B{I:1, j:2}}`},
This works but it makes the test a lot less rigorous.

Maybe put in a TODO to implement a map test that checks against all
permutations.

[r, 2011-10-18 00:45:28]

LGTM

[dsymonds, 2011-10-18 00:46:51]

http://codereview.appspot.com/5293043/diff/4001/src/pkg/fmt/fmt_test.go
File src/pkg/fmt/fmt_test.go (right):

http://codereview.appspot.com/5293043/diff/4001/src/pkg/fmt/fmt_test.go#newco...
src/pkg/fmt/fmt_test.go:353: {"%#v", map[string]B{"a": {1, 2}}, `map[string]
fmt_test.B{"a":fmt_test.B{I:1, j:2}}`},
On 2011/10/18 00:45:19, adg wrote:
> This works but it makes the test a lot less rigorous.
> 
> Maybe put in a TODO to implement a map test that checks against all
> permutations.

There's already a test lower down that covers that, TestMapPrinter.

[dsymonds, 2011-10-18 00:47:17]

*** Submitted as http://code.google.com/p/go/source/detail?r=ba08f59ca300 ***

fmt: fix test relying on map iteration order.

This fixes the 386 builds.

R=golang-dev, adg, r
CC=golang-dev
http://codereview.appspot.com/5293043