Issue 5275041: checkpkg: A better unit test interface

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5275041: checkpkg: A better unit test interface (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by automatthias

Modified:
12 years, 2 months ago

Reviewers:
bdwalton

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 1

Patch Set 2 : A simpler way to do this #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+229 lines, -402 lines)			Patch
	M	gar/v2/lib/python/package_checks.py	View	1	2 chunks	+6 lines, -8 lines	0 comments	Download
	M	gar/v2/lib/python/package_checks_test.py	View	1	70 chunks	+223 lines, -394 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

automatthias

12 years, 6 months ago (2011-10-15 16:26:39 UTC) #1

http://codereview.appspot.com/5275041/diff/1/gar/v2/lib/python/package_checks...
File gar/v2/lib/python/package_checks_test.py (right):

http://codereview.appspot.com/5275041/diff/1/gar/v2/lib/python/package_checks...
gar/v2/lib/python/package_checks_test.py:105: self.mox.VerifyAll()
It turns out that you can run VerifyAll in the tearDown() function, and it still
report the right test function name if the verification fails. So there's no
need to use the 'with' statement here at all.

Expand All Messages | Collapse All Messages