Issue 5268044: code review 5268044: 5l, 6l, 8l: correct ELFRESERVE diagnostic

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5268044: code review 5268044: 5l, 6l, 8l: correct ELFRESERVE diagnostic (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by ality

Modified:
13 years, 9 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

5l, 6l, 8l: correct ELFRESERVE diagnostic If the length of the interpreter string pushes us over the ELFRESERVE limit, the resulting error message will be comical. I was doing some ELF tinkering with a modified version of 8l when I hit this. To be clear, the stock linkers wouldn't hit this without adding about forty more section headers. We're safe for now. ;) Also, remove a redundant call to cflush.

Patch Set 1 #

Patch Set 2 : diff -r 9e73a59f386c https://code.google.com/p/go/ #

Patch Set 3 : diff -r 9e73a59f386c https://code.google.com/p/go/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
M	src/cmd/5l/asm.c	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/cmd/6l/asm.c	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/cmd/8l/asm.c	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ality

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

13 years, 9 months ago (2011-10-15 12:30:48 UTC) #1

rsc

13 years, 9 months ago (2011-10-18 20:05:40 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=835c4bc6a947 ***

5l, 6l, 8l: correct ELFRESERVE diagnostic

If the length of the interpreter string
pushes us over the ELFRESERVE limit, the
resulting error message will be comical.

I was doing some ELF tinkering with a
modified version of 8l when I hit this.

To be clear, the stock linkers wouldn't
hit this without adding about forty more
section headers.  We're safe for now. ;)

Also, remove a redundant call to cflush.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5268044

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages