Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(52)

Issue 5266042: code review 5266042: go/types: move to exp/types per Go 1 plan (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 5 months ago by gri
Modified:
14 years, 5 months ago
Reviewers:
CC:
rsc, r, golang-dev
Visibility:
Public.

Description

go/types: move to exp/types per Go 1 plan This package is only used by gotype at the moment.

Patch Set 1 #

Patch Set 2 : diff -r 9dfd4d3e763c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9dfd4d3e763c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 9dfd4d3e763c https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 9dfd4d3e763c https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 9dfd4d3e763c https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-7 lines, --7 lines) Patch
M src/cmd/gotype/gotype.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/Makefile View 1 2 2 chunks +1 line, -1 line 0 comments Download
M src/pkg/exp/types/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/types/check.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/check_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/const.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/exportdata.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/gcimporter.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/gcimporter_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/testdata/exports.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/testdata/test0.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/types.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/universe.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4
gri
Hello rsc@golang.org, r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years, 5 months ago (2011-10-13 22:36:32 UTC) #1
r
LGTM
14 years, 5 months ago (2011-10-13 22:40:47 UTC) #2
gri
Hello rsc@golang.org, r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years, 5 months ago (2011-10-13 22:41:46 UTC) #3
gri
14 years, 5 months ago (2011-10-13 22:41:53 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=d4587cd530d4 ***

go/types: move to exp/types per Go 1 plan

This package is only used by gotype at the moment.

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/5266042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b