Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(73)

Issue 5227041: code review 5227041: godoc: documentation for all (not just exported) declar... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by gri
Modified:
13 years, 10 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

godoc: documentation for all (not just exported) declarations Removed the URL form parameter "f=text" in favor of a more flexible mode parameter "m" which now accepts a list of mode flags as documented in doc.go. Fixes issue 1784.

Patch Set 1 #

Patch Set 2 : diff -r a71b3310c793 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a71b3310c793 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r a71b3310c793 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r a71b3310c793 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 594495a1b5ec https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -17 lines) Patch
M src/cmd/godoc/doc.go View 1 2 chunks +11 lines, -1 line 0 comments Download
M src/cmd/godoc/godoc.go View 1 2 3 6 chunks +40 lines, -12 lines 0 comments Download
M src/cmd/godoc/main.go View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 4
gri
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 10 months ago (2011-10-06 21:54:54 UTC) #1
gri
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 10 months ago (2011-10-06 22:40:58 UTC) #2
rsc
LGTM
13 years, 10 months ago (2011-10-06 22:56:07 UTC) #3
gri
13 years, 10 months ago (2011-10-06 23:06:27 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=b2a2889cfdf8 ***

godoc: documentation for all (not just exported) declarations

Removed the URL form parameter "f=text" in favor of a more
flexible mode parameter "m" which now accepts a list of mode
flags as documented in doc.go.

Fixes issue 1784.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5227041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b