code review 5223043: gotest: document -test.parallel

gotest: document -test.parallel

[r, 2011-10-06 16:58:27]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-10-06 17:12:00]

adverb? Simultaneously?
On Oct 6, 2011 9:58 AM, <r@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> gotest: document -test.parallel
>
> Please review this at
http://codereview.appspot.com/**5223043/<http://codereview.appspot.com/5223043/>
>
> Affected files:
>  M src/cmd/gotest/doc.go
>
>
> Index: src/cmd/gotest/doc.go
> ==============================**==============================**=======
> --- a/src/cmd/gotest/doc.go
> +++ b/src/cmd/gotest/doc.go
> @@ -54,6 +54,7 @@
>        6.out [-test.v] [-test.run pattern] [-test.bench pattern] \
>                [-test.cpuprofile=cpu.out] \
>                [-test.memprofile=mem.out] [-test.memprofilerate=1] \
> +               [-test.parallel=0] \
>                [-test.timeout=10] [-test.short] \
>                [-test.benchtime=3] [-test.cpu=1,2,3,4]
>
> @@ -86,6 +87,10 @@
>  Use -test.run or -test.bench to limit profiling to a particular test
>  or benchmark.
>
> +The -test.parallel flag allows parallel execution of Test functions
> +that call test.Parallel.  The value of the flag is the maximum number
> +of tests to run simultaneous.
> +
>  The -test.short flag tells long-running tests to shorten their run
>  time.  It is off by default but set by all.bash so installations of
>  the Go tree can do a sanity check but not spend time running
>
>
>

[dsymonds, 2011-10-06 17:32:02]

http://codereview.appspot.com/5223043/diff/1/src/cmd/gotest/doc.go
File src/cmd/gotest/doc.go (right):

http://codereview.appspot.com/5223043/diff/1/src/cmd/gotest/doc.go#newcode92
src/cmd/gotest/doc.go:92: of tests to run simultaneous.
I didn't follow the CL closely, so that probably makes me a good test case. What
does the default value of zero mean?

[r, 2011-10-06 17:36:18]

Hello golang-dev@googlegroups.com, bradfitz@golang.org, dsymonds@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[gri, 2011-10-06 17:38:12]

LGTM

[bradfitz, 2011-10-06 17:38:31]

LGTM

On Thu, Oct 6, 2011 at 10:36 AM, <r@golang.org> wrote:

> Hello golang-dev@googlegroups.com, bradfitz@golang.org,
> dsymonds@golang.org (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
http://codereview.appspot.com/**5223043/<http://codereview.appspot.com/5223043/>
>

[dsymonds, 2011-10-06 17:39:22]

LGTM

[r, 2011-10-06 17:41:57]

*** Submitted as http://code.google.com/p/go/source/detail?r=84bf0597069e ***

gotest: document -test.parallel

R=golang-dev, bradfitz, dsymonds, gri
CC=golang-dev
http://codereview.appspot.com/5223043