Issue 5183041: proposed ns-3 Spectrum API change: SpectrumSignalParameters

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5183041: proposed ns-3 Spectrum API change: SpectrumSignalParameters

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by Nicola Baldo

Modified:
12 years, 6 months ago

Reviewers:
Tom Henderson

CC:
ns-3-reviews_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+553 lines, -374 lines)			Patch
M	src/lte/model/lte-phy.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/lte/model/lte-spectrum-phy.h	View	4 chunks	+1 line, -19 lines	0 comments	Download
M	src/lte/model/lte-spectrum-phy.cc	View	5 chunks	+16 lines, -17 lines	0 comments	Download
A	src/lte/model/lte-spectrum-signal-parameters.h	View	1 chunk	+61 lines, -0 lines	0 comments	Download
A	src/lte/model/lte-spectrum-signal-parameters.cc	View	1 chunk	+49 lines, -0 lines	0 comments	Download
M	src/lte/wscript	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/spectrum/model/half-duplex-ideal-phy.h	View	2 chunks	+2 lines, -13 lines	0 comments	Download
M	src/spectrum/model/half-duplex-ideal-phy.cc	View	8 chunks	+33 lines, -30 lines	0 comments	Download
A	src/spectrum/model/half-duplex-ideal-phy-signal-parameters.h	View	1 chunk	+61 lines, -0 lines	0 comments	Download
A	src/spectrum/model/half-duplex-ideal-phy-signal-parameters.cc	View	1 chunk	+49 lines, -0 lines	0 comments	Download
M	src/spectrum/model/multi-model-spectrum-channel.h	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	src/spectrum/model/multi-model-spectrum-channel.cc	View	6 chunks	+23 lines, -20 lines	0 comments	Download
M	src/spectrum/model/single-model-spectrum-channel.h	View	2 chunks	+3 lines, -10 lines	0 comments	Download
M	src/spectrum/model/single-model-spectrum-channel.cc	View	4 chunks	+18 lines, -19 lines	0 comments	Download
M	src/spectrum/model/spectrum-analyzer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/spectrum/model/spectrum-analyzer.cc	View	1 chunk	+4 lines, -7 lines	0 comments	Download
M	src/spectrum/model/spectrum-channel.h	View	2 chunks	+4 lines, -14 lines	0 comments	Download
M	src/spectrum/model/spectrum-interference.cc	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	src/spectrum/model/spectrum-phy.h	View	3 chunks	+4 lines, -8 lines	0 comments	Download
A	src/spectrum/model/spectrum-signal-parameters.h	View	1 chunk	+113 lines, -0 lines	0 comments	Download
A	src/spectrum/model/spectrum-signal-parameters.cc	View	1 chunk	+59 lines, -0 lines	0 comments	Download
R	src/spectrum/model/spectrum-type.h	View	1 chunk	+0 lines, -86 lines	0 comments	Download
R	src/spectrum/model/spectrum-type.cc	View	1 chunk	+0 lines, -95 lines	0 comments	Download
M	src/spectrum/model/spectrum-value.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/spectrum/model/spectrum-value.cc	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	src/spectrum/model/waveform-generator.h	View	3 chunks	+1 line, -12 lines	0 comments	Download
M	src/spectrum/model/waveform-generator.cc	View	2 chunks	+7 lines, -13 lines	0 comments	Download
M	src/spectrum/wscript	View	4 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Tom Henderson

12 years, 6 months ago (2011-10-17 02:58:05 UTC) #1

I don't have any comments inline with the code.  I support the overall change
here and noticed the problems mentioned with the existing API when trying to use
it for LR-WPAN.

Expand All Messages | Collapse All Messages