Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(26)

Issue 5178044: [pph] Detect state mutation in DECLs/TYPEs [5/8] (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by Diego Novillo
Modified:
13 years, 6 months ago
Reviewers:
CC:
Lawrence Crowl, gcc-patches_gcc.gnu.org
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M gcc/cp/ChangeLog.pph View 1 chunk +4 lines, -0 lines 0 comments Download
M gcc/cp/pph-streamer.c View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 1
Diego Novillo
13 years, 7 months ago (2011-10-03 15:24:51 UTC) #1
Fixlet to update documentation for pph_cache_insert_at.


Diego.


	* pph-streamer.c (pph_cache_insert_at): Fix documentation.

diff --git a/gcc/cp/pph-streamer.c b/gcc/cp/pph-streamer.c
index d0fac57..26bc6cd 100644
--- a/gcc/cp/pph-streamer.c
+++ b/gcc/cp/pph-streamer.c
@@ -402,11 +402,9 @@ pph_trace_bitpack (pph_stream *stream, struct bitpack_d
*bp)
 }
 
 
-/* Insert DATA in CACHE at slot IX.  We support inserting the same
-   DATA at different locations of the array (FIXME pph, this happens
-   when reading builtins, which may have been converted into builtins
-   after they were read originally.  This should be detected and
-   converted into mutated references).  */
+/* Insert DATA in CACHE at slot IX.  As a restriction to prevent
+   stomping on cache entries, this will not allow inserting
+   into the same slot more than once.  */
 
 void
 pph_cache_insert_at (pph_cache *cache, void *data, unsigned ix)
-- 
1.7.3.1


--
This patch is available for review at http://codereview.appspot.com/5178044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b