Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1695)

Issue 5174041: [google] Specify target as ix86 or x86_64 for test builtin_target.c

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by Sriraman
Modified:
12 years, 7 months ago
Reviewers:
davidxl, rth
CC:
gcc-patches_gcc.gnu.org
Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/gcc-4_6/gcc/testsuite/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gcc.dg/builtin_target.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Sriraman
* testsuite/gcc.dg/builtin_target.c: Specify target as ix86 or x86_64. Index: gcc.dg/builtin_target.c =================================================================== --- gcc.dg/builtin_target.c (revision 179400) ...
12 years, 7 months ago (2011-09-30 21:09:51 UTC) #1
Sriraman
This is now submitted. Thanks, -Sri. On Fri, Sep 30, 2011 at 2:09 PM, Sriraman ...
12 years, 7 months ago (2011-09-30 21:32:14 UTC) #2
rth_redhat.com
On 09/30/2011 02:09 PM, Sriraman Tallam wrote: > * testsuite/gcc.dg/builtin_target.c: Specify target as ix86 or ...
12 years, 7 months ago (2011-09-30 21:33:06 UTC) #3
Sriraman
12 years, 7 months ago (2011-09-30 21:49:36 UTC) #4
Moving test gcc.target/i386

	* testsuite/gcc.dg/builtin_target.c: Remove.
	* testsuite/gcc.target/i386/builtin_target.c: New file.

On Fri, Sep 30, 2011 at 2:33 PM, Richard Henderson <rth@redhat.com> wrote:
> On 09/30/2011 02:09 PM, Sriraman Tallam wrote:
>>       * testsuite/gcc.dg/builtin_target.c: Specify target as ix86 or
>>       x86_64.
>>
>> Index: gcc.dg/builtin_target.c
>> ===================================================================
>> --- gcc.dg/builtin_target.c   (revision 179400)
>> +++ gcc.dg/builtin_target.c   (working copy)
>> @@ -1,6 +1,6 @@
>>  /* This test checks if the __builtin_cpu_* calls are recognized. */
>>
>> -/* { dg-do run } */
>> +/* { dg-do run { target i?86-*-* x86_64-*-* } } */
>
> This is an indication that the test is in the wrong place.
> It should be in gcc.target/i386/

Sorry, did not realize.


>
>
> r~
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b