Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(667)

Issue 5169041: Build dependencies for .texi files (issue 1852). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by janek
Modified:
12 years, 3 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Build dependencies for .texi files (issue 1852). Write .dep files containing make dependency rules for .texi files. These .dep files are generated by scanning for lines starting with @include in the .texi files. They are included into the build by the file stepmake/stepmake/generic-targets.make. With proper dependencies it became apparent that the build system does not operate correclty as make would then complain: *** No rule to make target `weblinks.itexi', needed by `out-www/web.texi'. Stop. This was triggered when we added the above dependency rules, and shows that the build system now attempts to build weblinks.itexi before compiling web.texi, but fails to do so because a rule is missing. Thus we add the missing rule to generate weblinks.texi to the local GNUmakefile in the Documentation folder. Another issue are @include for which the included files are in another directory, but that is not reflected in the @include. This produces wrong dependency targets since make would expect the included file in the same directory as the main file. Thus we se @include with the correct relative path in .texi files.

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M Documentation/GNUmakefile View 1 chunk +2 lines, -0 lines 0 comments Download
M Documentation/topdocs/AUTHORS.texi View 1 chunk +2 lines, -2 lines 3 comments Download
M Documentation/topdocs/INSTALL.texi View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/web.texi View 1 chunk +1 line, -1 line 0 comments Download
M stepmake/stepmake/texinfo-rules.make View 1 chunk +3 lines, -1 line 4 comments Download

Messages

Total messages: 7
janek
By Julien Rioux. I apologize for delay, i wasn't smart enough to get around 1491. ...
12 years, 6 months ago (2011-09-30 11:22:09 UTC) #1
Graham Percival (old account)
the GNUmakefile and texinfo-rules.make look good http://codereview.appspot.com/5169041/diff/1/Documentation/topdocs/AUTHORS.texi File Documentation/topdocs/AUTHORS.texi (right): http://codereview.appspot.com/5169041/diff/1/Documentation/topdocs/AUTHORS.texi#newcode13 Documentation/topdocs/AUTHORS.texi:13: @include ../macros.itexi this ...
12 years, 6 months ago (2011-09-30 11:41:50 UTC) #2
Reinhold
I don't really like the naive approach of using the exact include file as the ...
12 years, 6 months ago (2011-09-30 12:17:10 UTC) #3
Julien Rioux
Publish comments. http://codereview.appspot.com/5169041/diff/1/Documentation/topdocs/AUTHORS.texi File Documentation/topdocs/AUTHORS.texi (right): http://codereview.appspot.com/5169041/diff/1/Documentation/topdocs/AUTHORS.texi#newcode13 Documentation/topdocs/AUTHORS.texi:13: @include ../macros.itexi On 2011/09/30 11:41:50, Graham Percival ...
12 years, 6 months ago (2011-09-30 13:48:47 UTC) #4
janek
Hi, i'm back and sorting old things out. The Rietveld issue http://codereview.appspot.com/5169041/ for this should ...
12 years, 3 months ago (2011-12-25 22:05:00 UTC) #5
pkx166h
On 2011/12/25 22:05:00, janek wrote: > Hi, > > i'm back and sorting old things ...
12 years, 3 months ago (2011-12-26 00:33:36 UTC) #6
janek
12 years, 3 months ago (2011-12-26 08:28:11 UTC) #7
On 2011/12/26 00:33:36, J_lowe wrote:
> On 2011/12/25 22:05:00, janek wrote:
> > Hi,
> > 
> > i'm back and sorting old things out.  The Rietveld issue
> > http://codereview.appspot.com/5169041/ for this should be closed, am i
> > right?
> > 
> > Janek
> 
>
http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commit;h=d30221fa73101ba...
> 
> I think it is this.
> 
> James

ok, closed.
Thanks, Julien!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b