Issue 5158043: code review 5158043: math: remove the leading F from Fabs etc.

Issue 5158043: code review 5158043: math: remove the leading F from Fabs etc. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by r

Modified:
12 years, 7 months ago

Reviewers:

CC:
golang-dev, gri, dsymonds

Visibility:
Public.

Description

math: remove the leading F from Fabs etc. The letter is a holdover from C and unnecessary in Go. Gofix module included. Fixes issue 2306.

Patch Set 2 : diff -r 39de8f482ea8 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 39de8f482ea8 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r bc60e3827d04 https://go.googlecode.com/hg/ #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+210 lines, -105 lines)			Patch
M	src/cmd/gofix/Makefile	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	src/cmd/gofix/math.go	View	1 2 3	1 chunk	+57 lines, -0 lines	0 comments	Download
A	src/cmd/gofix/math_test.go	View	1	1 chunk	+47 lines, -0 lines	0 comments	Download
M	src/pkg/cmath/asin.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/cmath/sin.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/cmath/sqrt.go	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/cmath/tan.go	View	1	4 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/json/scanner_test.go	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/math/Makefile	View	1	4 chunks	+7 lines, -7 lines	0 comments	Download
M	src/pkg/math/abs.go	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/pkg/math/abs_386.s	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/math/abs_amd64.s	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/math/abs_decl.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/math/all_test.go	View	1	13 chunks	+39 lines, -39 lines	0 comments	Download
M	src/pkg/math/bits.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/math/dim.go	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/pkg/math/dim_amd64.s	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/math/dim_decl.go	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/math/gamma.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/math/jn.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/math/lgamma.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/math/mod.go	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/pkg/math/mod_386.s	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/math/mod_decl.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/math/pow.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/math/remainder.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/rand/rand_test.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 7 months ago (2011-09-29 16:36:22 UTC) #1

dsymonds

LGTM http://codereview.appspot.com/5158043/diff/4001/src/cmd/gofix/math.go File src/cmd/gofix/math.go (right): http://codereview.appspot.com/5158043/diff/4001/src/cmd/gofix/math.go#newcode45 src/cmd/gofix/math.go:45: // Rename functions and methods. s/ and methods/

12 years, 7 months ago (2011-09-29 16:40:57 UTC) #3

12 years, 7 months ago (2011-09-29 16:54:25 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=93c459658010 ***

math: remove the leading F from Fabs etc.
The letter is a holdover from C and unnecessary in Go.
Gofix module included.
Fixes issue 2306.

R=golang-dev, gri, dsymonds
CC=golang-dev
http://codereview.appspot.com/5158043

Expand All Messages | Collapse All Messages