Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(884)

Issue 5151045: Node update flags for delayed update calls (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by lukas.toenne
Modified:
12 years, 7 months ago
Reviewers:
bf-codereview
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

Adds an update flag to the bNode struct (similar to bNodeTree->update). This prevents access to non-existent typeinfo when during type initialization, when node types have been removed and such nodes are deleted from older files. All blenkernel functions now only set the node->update flag instead of directly calling the update function. All operators, etc. calling blenkernel functions to modify nodes should make a ntreeUpdate call afterward (they already did that anyway). Editor/RNA/renderer/etc. high-level functions still can do immediate updates by using nodeUpdate and nodeUpdateID (replacing NodeTagChanged/NodeTagIDChanged respectively). These old functions were previously used only for setting compositor node needexec flags and clearing cached data, but have become generic update functions that require type-specific functionality (i.e. a valid typeinfo struct).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -64 lines) Patch
M source/blender/blenkernel/BKE_node.h View 2 chunks +3 lines, -4 lines 0 comments Download
M source/blender/blenkernel/intern/depsgraph.c View 1 chunk +1 line, -1 line 0 comments Download
M source/blender/blenkernel/intern/image.c View 1 chunk +1 line, -1 line 0 comments Download
M source/blender/blenkernel/intern/node.c View 10 chunks +30 lines, -22 lines 0 comments Download
M source/blender/editors/render/render_internal.c View 1 chunk +2 lines, -2 lines 0 comments Download
M source/blender/editors/space_node/node_draw.c View 1 chunk +2 lines, -2 lines 0 comments Download
M source/blender/editors/space_node/node_edit.c View 9 chunks +11 lines, -11 lines 0 comments Download
M source/blender/editors/space_node/space_node.c View 1 chunk +2 lines, -2 lines 0 comments Download
M source/blender/makesdna/DNA_node_types.h View 2 chunks +10 lines, -1 line 0 comments Download
M source/blender/makesrna/intern/rna_nodetree.c View 2 chunks +2 lines, -2 lines 0 comments Download
M source/blender/nodes/composite/node_composite_tree.c View 8 chunks +16 lines, -11 lines 0 comments Download
M source/blender/nodes/intern/node_common.c View 2 chunks +4 lines, -2 lines 0 comments Download
M source/blender/nodes/shader/node_shader_tree.c View 2 chunks +6 lines, -1 line 0 comments Download
M source/blender/nodes/texture/node_texture_tree.c View 1 chunk +1 line, -1 line 0 comments Download
M source/blender/render/intern/source/pipeline.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1
lukas.toenne
12 years, 7 months ago (2011-09-30 10:20:57 UTC) #1

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b