Issue 5144043: code review 5144043: codereview: extra repo sanity check

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5144043: code review 5144043: codereview: extra repo sanity check (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by rsc

Modified:
13 years, 9 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

codereview: extra repo sanity check Also work around Mercurial issue 3023. If anyone has local changes in their repo (due to patch queues or whatever) stop them from leaking into the main repository.

Patch Set 1 #

Patch Set 2 : diff -r 033da0100eb6 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 033da0100eb6 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r bcebaf66e7a8 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r bcebaf66e7a8 https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -16 lines)			Patch
	M	lib/codereview/codereview.py	View	1 2 3	7 chunks	+38 lines, -16 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-09-26 16:56:06 UTC) #1

rsc

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 9 months ago (2011-09-26 18:19:52 UTC) #2

rsc

I added a bug fix to this CL that I needed to work around a ...

13 years, 9 months ago (2011-09-26 18:21:07 UTC) #3

rsc

13 years, 9 months ago (2011-09-26 22:32:20 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=583b7464b4e3 ***

codereview: extra repo sanity check

Also work around Mercurial issue 3023.

If anyone has local changes in their repo (due to
patch queues or whatever) stop them from leaking
into the main repository.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5144043

Expand All Messages | Collapse All Messages