Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3148)

Issue 5096046: Doc: add a note about \relative f to notation (issue 1909) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by janek
Modified:
12 years, 7 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: add a note about \relative f to notation

Patch Set 1 #

Total comments: 5

Patch Set 2 : shortify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Documentation/notation/pitches.itely View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9
janek
http://lists.gnu.org/archive/html/lilypond-devel/2011-09/msg00331.html http://code.google.com/p/lilypond/issues/detail?id=1909
12 years, 7 months ago (2011-09-21 07:20:46 UTC) #1
dak
http://codereview.appspot.com/5096046/diff/1/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/5096046/diff/1/Documentation/notation/pitches.itely#newcode258 Documentation/notation/pitches.itely:258: If you carefully consider all the rules above and ...
12 years, 7 months ago (2011-09-21 07:50:04 UTC) #2
pkx166h
Suggestion to text. http://codereview.appspot.com/5096046/diff/1/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/5096046/diff/1/Documentation/notation/pitches.itely#newcode263 Documentation/notation/pitches.itely:263: Janek, something 'like' this: Absolute pitch ...
12 years, 7 months ago (2011-09-21 09:51:09 UTC) #3
dak
pkx166h@gmail.com writes: > Suggestion to text. > > > http://codereview.appspot.com/5096046/diff/1/Documentation/notation/pitches.itely > File Documentation/notation/pitches.itely (right): > ...
12 years, 7 months ago (2011-09-21 10:36:37 UTC) #4
Graham Percival (old account)
http://codereview.appspot.com/5096046/diff/1/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/5096046/diff/1/Documentation/notation/pitches.itely#newcode258 Documentation/notation/pitches.itely:258: If you carefully consider all the rules above and ...
12 years, 7 months ago (2011-09-21 19:31:29 UTC) #5
janek
I've made this briefer according to your suggestions. beers, Janek http://codereview.appspot.com/5096046/diff/1/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/5096046/diff/1/Documentation/notation/pitches.itely#newcode258 ...
12 years, 7 months ago (2011-09-25 17:43:37 UTC) #6
dak
LGTM
12 years, 7 months ago (2011-09-25 21:40:29 UTC) #7
Graham Percival (old account)
LGTM. If you wanted to add a @lilypond to make it more visible, I'm happy ...
12 years, 7 months ago (2011-09-26 05:26:14 UTC) #8
janek
12 years, 7 months ago (2011-09-26 10:32:43 UTC) #9
2011/9/26  <percival.music.ca@gmail.com>:
> LGTM.  If you wanted to add a @lilypond to make it more visible, I'm
> happy with that, otherwise just go ahead and push.

pushed 0d4c0b0979c200e54cffc6b68671df50d6b90a49

I've accidentally created a new branch 'relativef' in savannah
repository - sorry for that, it was a typo.  I've deleted it already.

cheers,
Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b