Issue 5081051: code review 5081051: test: match gccgo error messages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5081051: code review 5081051: test: match gccgo error messages (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by iant

Modified:
13 years, 8 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

test: match gccgo error messages bug363.go:13:12: error: invalid context-determined non-integer type for shift operand bug363.go:16:12: error: invalid context-determined non-integer type for shift operand pointer.go:34:6: error: incompatible type in initialization (pointer to interface type has no methods) pointer.go:36:6: error: incompatible type in initialization method2.go:15:1: error: invalid pointer or interface receiver type method2.go:16:1: error: invalid pointer or interface receiver type method2.go:21:1: error: invalid pointer or interface receiver type method2.go:22:1: error: invalid pointer or interface receiver type method2.go:28:15: error: type ‘*Val’ has no method ‘val’ method2.go:33:11: error: reference to undefined field or method ‘val’ shift1.go:19:16: error: invalid context-determined non-integer type for shift operand shift1.go:24:19: error: invalid context-determined non-integer type for shift operand shift1.go:25:17: error: invalid context-determined non-integer type for shift operand shift1.go:18:18: error: shift of non-integer operand shift1.go:26:13: error: floating point constant truncated to integer shift1.go:33:15: error: integer constant overflow shift1.go:34:15: error: integer constant overflow shift1.go:35:17: error: integer constant overflow

Patch Set 1 #

Patch Set 2 : diff -r 387f8f80bf20 https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -11 lines)			Patch
M	test/fixedbugs/bug363.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/interface/pointer.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/method2.go	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	test/shift1.go	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-09-21 23:40:19 UTC) #1

iant

13 years, 8 months ago (2011-09-22 00:25:59 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=8cbe5194c6e9 ***

test: match gccgo error messages

bug363.go:13:12: error: invalid context-determined non-integer type for shift
operand
bug363.go:16:12: error: invalid context-determined non-integer type for shift
operand

pointer.go:34:6: error: incompatible type in initialization (pointer to
interface type has no methods)
pointer.go:36:6: error: incompatible type in initialization

method2.go:15:1: error: invalid pointer or interface receiver type
method2.go:16:1: error: invalid pointer or interface receiver type
method2.go:21:1: error: invalid pointer or interface receiver type
method2.go:22:1: error: invalid pointer or interface receiver type
method2.go:28:15: error: type ‘*Val’ has no method ‘val’
method2.go:33:11: error: reference to undefined field or method ‘val’

shift1.go:19:16: error: invalid context-determined non-integer type for shift
operand
shift1.go:24:19: error: invalid context-determined non-integer type for shift
operand
shift1.go:25:17: error: invalid context-determined non-integer type for shift
operand
shift1.go:18:18: error: shift of non-integer operand
shift1.go:26:13: error: floating point constant truncated to integer
shift1.go:33:15: error: integer constant overflow
shift1.go:34:15: error: integer constant overflow
shift1.go:35:17: error: integer constant overflow

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5081051

Expand All Messages | Collapse All Messages