Issue 5078046: code review 5078046: test: match gccgo error messages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5078046: code review 5078046: test: match gccgo error messages (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by iant

Modified:
13 years, 9 months ago

Reviewers:

CC:
golang-dev, gri

Visibility:
Public.

Description

test: match gccgo error messages Added a return to bug357.go to avoid an error which gccgo reports but 6g does not. bug353.go:16:14: error: reference to undefined identifer ‘io.ReadWriterCloser’ bug357.go:18:2: error: value computed is not used bug358.go:14:11: error: imported and not used: ioutil bug358.go:19:9: error: invalid use of type bug359.go:25:14: error: redefinition of ‘a’ bug359.go:25:6: note: previous definition of ‘a’ was here bug359.go:19:6: error: incompatible type in initialization (implicit assignment of ‘list.List’ hidden field ‘front’) bug362.go:13:6: error: iota is only defined in const declarations bug362.go:14:6: error: iota is only defined in const declarations bug362.go:15:6: error: iota is only defined in const declarations bug363.go:13:12: error: shift of non-integer operand bug363.go:16:12: error: shift of non-integer operand bug365.go:15:8: error: expected package

Patch Set 1 #

Patch Set 2 : diff -r 816084723d99 https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -12 lines)			Patch
M	test/fixedbugs/bug353.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/fixedbugs/bug357.go	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/fixedbugs/bug358.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/fixedbugs/bug359.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/fixedbugs/bug362.go	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	test/fixedbugs/bug363.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/fixedbugs/bug365.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-09-20 22:50:27 UTC) #1

iant

13 years, 9 months ago (2011-09-20 23:47:31 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=d0ffb84a698e ***

test: match gccgo error messages

Added a return to bug357.go to avoid an error which gccgo
reports but 6g does not.

bug353.go:16:14: error: reference to undefined identifer ‘io.ReadWriterCloser’

bug357.go:18:2: error: value computed is not used

bug358.go:14:11: error: imported and not used: ioutil
bug358.go:19:9: error: invalid use of type

bug359.go:25:14: error: redefinition of ‘a’
bug359.go:25:6: note: previous definition of ‘a’ was here
bug359.go:19:6: error: incompatible type in initialization (implicit assignment
of ‘list.List’ hidden field ‘front’)

bug362.go:13:6: error: iota is only defined in const declarations
bug362.go:14:6: error: iota is only defined in const declarations
bug362.go:15:6: error: iota is only defined in const declarations

bug363.go:13:12: error: shift of non-integer operand
bug363.go:16:12: error: shift of non-integer operand

bug365.go:15:8: error: expected package

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5078046

Expand All Messages | Collapse All Messages