Issue 5061042: code review 5061042: net: use /etc/hosts first when looking up IP addresses ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5061042: code review 5061042: net: use /etc/hosts first when looking up IP addresses ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by aam

Modified:
13 years, 10 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

net: use /etc/hosts first when looking up IP addresses using native Go's dns resolver Previously /etc/hosts would be ignored altogether, this change returns matching results from that file without talking to a DNS server.

Patch Set 1 #

Patch Set 2 : diff -r 2e00b068ff36 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2e00b068ff36 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r aa52ecabceb1 https://go.googlecode.com/hg/ #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	src/pkg/net/dnsclient_unix.go	View	1 2 3	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

aam

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 10 months ago (2011-09-18 20:32:31 UTC) #1

rsc

http://codereview.appspot.com/5061042/diff/4001/src/pkg/net/dnsclient_unix.go File src/pkg/net/dnsclient_unix.go (right): http://codereview.appspot.com/5061042/diff/4001/src/pkg/net/dnsclient_unix.go#newcode222 src/pkg/net/dnsclient_unix.go:222: addrs = append(addrs, ParseIP(haddr)) if ip := ParseIP(haddr); ip ...

13 years, 10 months ago (2011-09-19 14:27:07 UTC) #2

aam

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 10 months ago (2011-09-19 14:44:28 UTC) #3

rsc

13 years, 10 months ago (2011-09-19 15:50:35 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=c754a98e6cd3 ***

net: use /etc/hosts first when looking up IP addresses using native Go's dns
resolver

Previously /etc/hosts would be ignored altogether, this change returns matching
results
from that file without talking to a DNS server.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5061042

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages